You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by eymorale <gi...@git.apache.org> on 2016/02/16 16:49:30 UTC
[GitHub] cordova-plugin-whitelist pull request: CB-10624 remove error messa...
GitHub user eymorale opened a pull request:
https://github.com/apache/cordova-plugin-whitelist/pull/17
CB-10624 remove error message from whitelist.js, which leaves it empty
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/eymorale/cordova-plugin-whitelist CB-10624
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-whitelist/pull/17.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #17
----
commit a50abe34afb4d62f84eec844f733e5fd8c890c86
Author: Edna Morales <ed...@gmail.com>
Date: 2016-02-16T14:57:56Z
CB-10624 remove error message from whitelist.js, which leaves it empty
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-whitelist pull request: CB-10624 remove error messa...
Posted by eymorale <gi...@git.apache.org>.
Github user eymorale commented on the pull request:
https://github.com/apache/cordova-plugin-whitelist/pull/17#issuecomment-184741324
@infil00p and @csantanapr can you take a look at this and see if you have any problems with it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-whitelist pull request: CB-10624 remove error messa...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-whitelist/pull/17
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-whitelist pull request: CB-10624 remove error messa...
Posted by csantanapr <gi...@git.apache.org>.
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-plugin-whitelist/pull/17#issuecomment-185330171
I agree we should remove the file all together is not required for functionality that the plugin offers.
@infil00p Are you OK with the removal of the js file?
@infil00p the error message is anorying and confusing to developers in the console.
CSP is not required for the Whitelist code to work. I think we should also move the CSP info from the README to the Security Guide in the docs, it gives the false impresion that the cordova plugin is parsing the CSP tag and processing and doing something with it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-whitelist pull request: CB-10624 remove error messa...
Posted by jcesarmobile <gi...@git.apache.org>.
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-whitelist/pull/17#issuecomment-185598264
+1
In addition, it's not consistent with other platforms. Android is the only one that shows this warning.
We should encorage users to use the CSP, but not sure if showing a warning is the best way of doing it.
Most answers on stackoverflow questiongs about this warning just tell how to use an empty CSP so it stops complaining or use CSP that allows everything.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-whitelist pull request: CB-10624 remove error messa...
Posted by csantanapr <gi...@git.apache.org>.
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-plugin-whitelist/pull/17#issuecomment-186021548
Thanks @jcesarmobile for commenting we wanted someone to review it before we took it out.
@eymorale looks like it's OK to go ahead and remove then.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org