You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/11 17:02:33 UTC
[GitHub] [flink] Myasuka opened a new pull request #14611: [FLINK-13194][docs] Add explicit clarification about thread-safety of state
Myasuka opened a new pull request #14611:
URL: https://github.com/apache/flink/pull/14611
## What is the purpose of the change
Add explicit clarification about thread-safety of state access.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14611: [FLINK-13194][docs] Add explicit clarification about thread-safety of state
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14611:
URL: https://github.com/apache/flink/pull/14611#issuecomment-758090584
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 73ffcc76bc3ca83b9c3e09309ef9174e9e676694 (Mon Jan 11 17:05:25 UTC 2021)
✅no warnings
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14611: [FLINK-13194][docs] Add explicit clarification about thread-safety of state
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14611:
URL: https://github.com/apache/flink/pull/14611#issuecomment-758104213
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "73ffcc76bc3ca83b9c3e09309ef9174e9e676694",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "73ffcc76bc3ca83b9c3e09309ef9174e9e676694",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 73ffcc76bc3ca83b9c3e09309ef9174e9e676694 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14611: [FLINK-13194][docs] Add explicit clarification about thread-safety of state
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14611:
URL: https://github.com/apache/flink/pull/14611#issuecomment-758104213
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "73ffcc76bc3ca83b9c3e09309ef9174e9e676694",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11892",
"triggerID" : "73ffcc76bc3ca83b9c3e09309ef9174e9e676694",
"triggerType" : "PUSH"
}, {
"hash" : "528835d01452384bd0f3708d31817812e246b230",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12275",
"triggerID" : "528835d01452384bd0f3708d31817812e246b230",
"triggerType" : "PUSH"
}, {
"hash" : "145e976456e1f3d765fbcb5f4e34e256949ae1ec",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12316",
"triggerID" : "145e976456e1f3d765fbcb5f4e34e256949ae1ec",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 145e976456e1f3d765fbcb5f4e34e256949ae1ec Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12316)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14611: [FLINK-13194][docs] Add explicit clarification about thread-safety of state
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14611:
URL: https://github.com/apache/flink/pull/14611#issuecomment-758104213
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "73ffcc76bc3ca83b9c3e09309ef9174e9e676694",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11892",
"triggerID" : "73ffcc76bc3ca83b9c3e09309ef9174e9e676694",
"triggerType" : "PUSH"
}, {
"hash" : "528835d01452384bd0f3708d31817812e246b230",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "528835d01452384bd0f3708d31817812e246b230",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 73ffcc76bc3ca83b9c3e09309ef9174e9e676694 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11892)
* 528835d01452384bd0f3708d31817812e246b230 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14611: [FLINK-13194][docs] Add explicit clarification about thread-safety of state
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14611:
URL: https://github.com/apache/flink/pull/14611#issuecomment-758104213
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "73ffcc76bc3ca83b9c3e09309ef9174e9e676694",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11892",
"triggerID" : "73ffcc76bc3ca83b9c3e09309ef9174e9e676694",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 73ffcc76bc3ca83b9c3e09309ef9174e9e676694 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11892)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] carp84 commented on pull request #14611: [FLINK-13194][docs] Add explicit clarification about thread-safety of state
Posted by GitBox <gi...@apache.org>.
carp84 commented on pull request #14611:
URL: https://github.com/apache/flink/pull/14611#issuecomment-758134270
Did some searching and now I'm even wondering whether there're any places in our document describing the thread modeling of Flink operators. I could see many questions on stackoverflow but without answer like [this one](https://stackoverflow.com/questions/61809836/flink-internal-threading-model-design). If there isn't any, we should write one (although might be a different topic than proposal in this PR).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14611: [FLINK-13194][docs] Add explicit clarification about thread-safety of state
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14611:
URL: https://github.com/apache/flink/pull/14611#issuecomment-758104213
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14611: [FLINK-13194][docs] Add explicit clarification about thread-safety of state
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14611:
URL: https://github.com/apache/flink/pull/14611#issuecomment-758090584
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 145e976456e1f3d765fbcb5f4e34e256949ae1ec (Fri May 28 07:11:30 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka commented on pull request #14611: [FLINK-13194][docs] Add explicit clarification about thread-safety of state
Posted by GitBox <gi...@apache.org>.
Myasuka commented on pull request #14611:
URL: https://github.com/apache/flink/pull/14611#issuecomment-763470968
@carp84 Thanks for your review, I have refactored this PR. However, I don't think we might need add an entry in our [state document](https://ci.apache.org/projects/flink/flink-docs-stable/dev/stream/state/) as current entries are all pointed to pages, while this state access description should only be just one session in [state doc](https://ci.apache.org/projects/flink/flink-docs-release-1.12/dev/stream/state/state.html).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski edited a comment on pull request #14611: [FLINK-13194][docs] Add explicit clarification about thread-safety of state
Posted by GitBox <gi...@apache.org>.
pnowojski edited a comment on pull request #14611:
URL: https://github.com/apache/flink/pull/14611#issuecomment-762238606
@carp84 , doesn't [this section in the docs](https://ci.apache.org/projects/flink/flink-docs-release-1.12/concepts/flink-architecture.html#tasks-and-operator-chains) address this topic? It's not much, but maybe it's enough?
> For distributed execution, Flink chains operator subtasks together into tasks. Each task is executed by one thread. (...)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14611: [FLINK-13194][docs] Add explicit clarification about thread-safety of state
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14611:
URL: https://github.com/apache/flink/pull/14611#issuecomment-758104213
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "73ffcc76bc3ca83b9c3e09309ef9174e9e676694",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11892",
"triggerID" : "73ffcc76bc3ca83b9c3e09309ef9174e9e676694",
"triggerType" : "PUSH"
}, {
"hash" : "528835d01452384bd0f3708d31817812e246b230",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12275",
"triggerID" : "528835d01452384bd0f3708d31817812e246b230",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 73ffcc76bc3ca83b9c3e09309ef9174e9e676694 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11892)
* 528835d01452384bd0f3708d31817812e246b230 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12275)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14611: [FLINK-13194][docs] Add explicit clarification about thread-safety of state
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14611:
URL: https://github.com/apache/flink/pull/14611#issuecomment-758104213
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "73ffcc76bc3ca83b9c3e09309ef9174e9e676694",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11892",
"triggerID" : "73ffcc76bc3ca83b9c3e09309ef9174e9e676694",
"triggerType" : "PUSH"
}, {
"hash" : "528835d01452384bd0f3708d31817812e246b230",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12275",
"triggerID" : "528835d01452384bd0f3708d31817812e246b230",
"triggerType" : "PUSH"
}, {
"hash" : "145e976456e1f3d765fbcb5f4e34e256949ae1ec",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12316",
"triggerID" : "145e976456e1f3d765fbcb5f4e34e256949ae1ec",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 528835d01452384bd0f3708d31817812e246b230 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12275)
* 145e976456e1f3d765fbcb5f4e34e256949ae1ec Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12316)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] carp84 commented on pull request #14611: [FLINK-13194][docs] Add explicit clarification about thread-safety of state
Posted by GitBox <gi...@apache.org>.
carp84 commented on pull request #14611:
URL: https://github.com/apache/flink/pull/14611#issuecomment-758126666
Thanks for creating the PR @Myasuka but I think the current changes are not that on track.
I think we should refine/add documents in multiple places, including:
1. As @StefanRRichter pointed out in the [JIRA comment](https://issues.apache.org/jira/browse/FLINK-13072?focusedCommentId=16879099&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16879099), the [javadoc](https://github.com/apache/flink/blob/master/flink-runtime/src/main/java/org/apache/flink/runtime/state/StateBackend.java#L85-L88) of `StateBackend` interface means the creation of backend instances should be thread-safe (although I'm even not 100% sure whether this is true in our current implementations) and we should refine it to be more clear.
2. We should add document in the `KeyedStateBackend` interface to clearly clarify that these interfaces are not thread-safe.
3. We need to add an entry in our [state document](https://ci.apache.org/projects/flink/flink-docs-stable/dev/stream/state/) about the single-threaded model of state access. Maybe an entry like "Thread safety of state access" with some simple contents like "All operators in Flink are assumed to be single-threaded and spawning up threads in any user function is something that is not supported by the framework. For the same reason, state access should be single-threaded and reading/writing states with multiple threads in user-defined-functions are not supported"
And I suggest we write a blog to further describe the single-threaded modeling of Flink operators and what kind of result breaking the rule would lead to in the perspective of state (such as the snapshotted data might be modified unexpectedly).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14611: [FLINK-13194][docs] Add explicit clarification about thread-safety of state
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14611:
URL: https://github.com/apache/flink/pull/14611#issuecomment-758104213
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "73ffcc76bc3ca83b9c3e09309ef9174e9e676694",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11892",
"triggerID" : "73ffcc76bc3ca83b9c3e09309ef9174e9e676694",
"triggerType" : "PUSH"
}, {
"hash" : "528835d01452384bd0f3708d31817812e246b230",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12275",
"triggerID" : "528835d01452384bd0f3708d31817812e246b230",
"triggerType" : "PUSH"
}, {
"hash" : "145e976456e1f3d765fbcb5f4e34e256949ae1ec",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "145e976456e1f3d765fbcb5f4e34e256949ae1ec",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 528835d01452384bd0f3708d31817812e246b230 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12275)
* 145e976456e1f3d765fbcb5f4e34e256949ae1ec UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14611: [FLINK-13194][docs] Add explicit clarification about thread-safety of state
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14611:
URL: https://github.com/apache/flink/pull/14611#issuecomment-758104213
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "73ffcc76bc3ca83b9c3e09309ef9174e9e676694",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11892",
"triggerID" : "73ffcc76bc3ca83b9c3e09309ef9174e9e676694",
"triggerType" : "PUSH"
}, {
"hash" : "528835d01452384bd0f3708d31817812e246b230",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12275",
"triggerID" : "528835d01452384bd0f3708d31817812e246b230",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 528835d01452384bd0f3708d31817812e246b230 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12275)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski commented on pull request #14611: [FLINK-13194][docs] Add explicit clarification about thread-safety of state
Posted by GitBox <gi...@apache.org>.
pnowojski commented on pull request #14611:
URL: https://github.com/apache/flink/pull/14611#issuecomment-762238606
@carp84 , doesn't [this section in the docs](https://ci.apache.org/projects/flink/flink-docs-release-1.12/concepts/flink-architecture.html#tasks-and-operator-chains) address this topic?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] carp84 edited a comment on pull request #14611: [FLINK-13194][docs] Add explicit clarification about thread-safety of state
Posted by GitBox <gi...@apache.org>.
carp84 edited a comment on pull request #14611:
URL: https://github.com/apache/flink/pull/14611#issuecomment-758134270
Did some searching and now I'm even wondering whether there're any places in our document describing the thread modeling of Flink operators. I could see many questions on stackoverflow but without answer like [this one](https://stackoverflow.com/questions/61809836/flink-internal-threading-model-design). @AHeise @pnowojski could you shed some lights here? Thanks.
If there isn't any, we should write one (although might be a different topic than proposal in this PR).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org