You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Adrian Cole <no...@github.com> on 2014/11/17 06:54:18 UTC
[jclouds-karaf] rm management (#62)
some missed cleanup work.
You can merge this Pull Request by running:
git pull https://github.com/adriancole/jclouds-karaf adrian.rm-management
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-karaf/pull/62
-- Commit Summary --
* Revert "[JCLOUDS-14] Add jclouds-management support"
* Removed antique nodepool dependency,
-- File Changes --
M feature/pom.xml (1)
M feature/src/main/resources/feature.xml (12)
M itests/src/test/java/org/jclouds/karaf/itests/MiscFeaturesInstallationTest.java (5)
M pom.xml (5)
M services/pom.xml (5)
M services/src/main/java/org/jclouds/karaf/services/internal/BlobStoreServiceFactory.java (4)
M services/src/main/java/org/jclouds/karaf/services/internal/ComputeServiceFactory.java (4)
-- Patch Links --
https://github.com/jclouds/jclouds-karaf/pull/62.patch
https://github.com/jclouds/jclouds-karaf/pull/62.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/62
Re: [jclouds-karaf] rm management (#62)
Posted by Ignasi Barrera <no...@github.com>.
The chef failure seems to be real. IIRC, chef uses Guice multi-bindings for the Ohai support. Could you try adding it back?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/62#issuecomment-63312569
Re: [jclouds-karaf] rm management (#62)
Posted by Ignasi Barrera <no...@github.com>.
> I removed guice multi-bindings?
Yep (at least with my very little understanding on karat :)). I've just commented in the affected line.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/62#issuecomment-63327737
Re: [jclouds-karaf] rm management (#62)
Posted by Adrian Cole <no...@github.com>.
merged into master and also 1.8.x as these are defunct in 1.8.x
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/62#issuecomment-63331167
Re: [jclouds-karaf] rm management (#62)
Posted by Adrian Cole <no...@github.com>.
@nacx @ccustine
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/62#issuecomment-63262867
Re: [jclouds-karaf] rm management (#62)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-karaf-pull-requests #104](https://jclouds.ci.cloudbees.com/job/jclouds-karaf-pull-requests/104/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/62#issuecomment-63330521
Re: [jclouds-karaf] rm management (#62)
Posted by Adrian Cole <no...@github.com>.
> @@ -22,7 +22,6 @@ limitations under the License.
> <bundle dependency='true'>mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.aopalliance/${aopalliance.bundle.version}</bundle>
> <bundle>mvn:com.google.inject/guice/${guice.version}</bundle>
> <bundle>mvn:com.google.inject.extensions/guice-assistedinject/${guice.version}</bundle>
> - <bundle>mvn:com.google.inject.extensions/guice-multibindings/${guice.version}</bundle>
ahh eyes crossed! must have been a part of the revert. will do.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/62/files#r20444392
Re: [jclouds-karaf] rm management (#62)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-karaf #1444](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-karaf/1444/) UNSTABLE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/62#issuecomment-63268802
Re: [jclouds-karaf] rm management (#62)
Posted by Adrian Cole <no...@github.com>.
I removed guice multi-bindings?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/62#issuecomment-63326991
Re: [jclouds-karaf] rm management (#62)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-karaf #1446](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-karaf/1446/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/62#issuecomment-63337155
Re: [jclouds-karaf] rm management (#62)
Posted by Ignasi Barrera <no...@github.com>.
> @@ -22,7 +22,6 @@ limitations under the License.
> <bundle dependency='true'>mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.aopalliance/${aopalliance.bundle.version}</bundle>
> <bundle>mvn:com.google.inject/guice/${guice.version}</bundle>
> <bundle>mvn:com.google.inject.extensions/guice-assistedinject/${guice.version}</bundle>
> - <bundle>mvn:com.google.inject.extensions/guice-multibindings/${guice.version}</bundle>
Add this back?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/62/files#r20444321
Re: [jclouds-karaf] rm management (#62)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-karaf-pull-requests #103](https://jclouds.ci.cloudbees.com/job/jclouds-karaf-pull-requests/103/) UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/62#issuecomment-63263394