You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Kristian Rosenvold <kr...@zenior.no> on 2014/11/16 13:44:10 UTC
r1639526 in maven-project-info-reports breaks the build
Michael,
The MPIR-279 fix broke the build (run with -Prun-its), it seems to me
like a "real" regression.
Kristian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: r1639526 in maven-project-info-reports breaks the build
Posted by Hervé BOUTEMY <he...@free.fr>.
Le dimanche 23 novembre 2014 10:27:12 Michael Osipov a écrit :
> Am 2014-11-23 um 03:42 schrieb Hervé BOUTEMY:
> > IMHO, just open another Jira issue and make the proper fix (with existing
> > ITs)
> I head this in my too, the question is. How do we want to unify that.
>
> Do we want everywhere:
>
> g:a:v or Unnamed -- g:a:v?
IMHO, simply artifactId, like it is done in reactor summary after build, is
the right module name to use by default: in general, the handwritten name is
like artifactId
>
> That would count for the module report as well as the modules menu.
> Probably for the breadcrumb too.
I just checked: artifactId is already the default value for breadcrumbs
but yes, this should be the default value for modules menu too
Regards,
Hervé
>
> Michael
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: r1639526 in maven-project-info-reports breaks the build
Posted by Michael Osipov <mi...@apache.org>.
Am 2014-11-23 um 03:42 schrieb Hervé BOUTEMY:
> IMHO, just open another Jira issue and make the proper fix (with existing ITs)
I head this in my too, the question is. How do we want to unify that.
Do we want everywhere:
g:a:v or Unnamed -- g:a:v?
That would count for the module report as well as the modules menu.
Probably for the breadcrumb too.
Michael
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: r1639526 in maven-project-info-reports breaks the build
Posted by Hervé BOUTEMY <he...@free.fr>.
IMHO, just open another Jira issue and make the proper fix (with existing ITs)
Regards,
Hervé
Le samedi 22 novembre 2014 19:40:12 Michael Osipov a écrit :
> > Gesendet: Samstag, 22. November 2014 um 19:02 Uhr
> > Von: "Hervé BOUTEMY" <he...@free.fr>
> > An: "Maven Developers List" <de...@maven.apache.org>
> > Betreff: Re: r1639526 in maven-project-info-reports breaks the build
> >
> > fixed
> >
> > was both:
> > 1. an existing IT weakness (missing distributionManagement section, which
> > cannot exist in real use case): I fixed the IT
>
> Thanks for the fix.
>
> > 2. and a change in output in case no name defined in module pom: I
> > reverted to previous algorithm (use artifactId) instead of ugly "Unnamed
> > g:a:v"
> I am against that. I added this on purpose. It resembles the output of the
> site tool which generates the modules menu. It looks awkward if both outputs
> aren't uniform.
>
> Michael
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Re: r1639526 in maven-project-info-reports breaks the build
Posted by Michael Osipov <19...@gmx.net>.
> Gesendet: Samstag, 22. November 2014 um 19:02 Uhr
> Von: "Hervé BOUTEMY" <he...@free.fr>
> An: "Maven Developers List" <de...@maven.apache.org>
> Betreff: Re: r1639526 in maven-project-info-reports breaks the build
>
> fixed
>
> was both:
> 1. an existing IT weakness (missing distributionManagement section, which
> cannot exist in real use case): I fixed the IT
Thanks for the fix.
> 2. and a change in output in case no name defined in module pom: I reverted to
> previous algorithm (use artifactId) instead of ugly "Unnamed g:a:v"
I am against that. I added this on purpose. It resembles the output of the
site tool which generates the modules menu. It looks awkward if both outputs
aren't uniform.
Michael
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: r1639526 in maven-project-info-reports breaks the build
Posted by Hervé BOUTEMY <he...@free.fr>.
fixed
was both:
1. an existing IT weakness (missing distributionManagement section, which
cannot exist in real use case): I fixed the IT
2. and a change in output in case no name defined in module pom: I reverted to
previous algorithm (use artifactId) instead of ugly "Unnamed g:a:v"
Regards,
Hervé
Le dimanche 16 novembre 2014 13:44:10 Kristian Rosenvold a écrit :
> Michael,
>
> The MPIR-279 fix broke the build (run with -Prun-its), it seems to me
> like a "real" regression.
>
> Kristian
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org