You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/09/11 20:37:09 UTC
[jira] [Commented] (CB-14242) Remove bundledDependencies &
committed node_modules from cordova-ios
[ https://issues.apache.org/jira/browse/CB-14242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611213#comment-16611213 ]
ASF GitHub Bot commented on CB-14242:
-------------------------------------
codecov-io edited a comment on issue #388: CB-14242 remove bundledDependencies and committed node_modules
URL: https://github.com/apache/cordova-ios/pull/388#issuecomment-409807256
# [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/388?src=pr&el=h1) Report
> Merging [#388](https://codecov.io/gh/apache/cordova-ios/pull/388?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/004b8300456816cc614d229e85a35a8bc37d363d?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-ios/pull/388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #388 +/- ##
=======================================
Coverage 74.29% 74.29%
=======================================
Files 12 12
Lines 1564 1564
=======================================
Hits 1162 1162
Misses 402 402
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/388?src=pr&el=footer). Last update [004b830...32b079e](https://codecov.io/gh/apache/cordova-ios/pull/388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Remove bundledDependencies & committed node_modules from cordova-ios
> --------------------------------------------------------------------
>
> Key: CB-14242
> URL: https://issues.apache.org/jira/browse/CB-14242
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: cordova-ios
> Reporter: Chris Brody
> Assignee: Chris Brody
> Priority: Major
>
> As described in parent task CB-14241: now that next major "-dev" release is marked (cordova-ios@5.0.0-dev) and CB-14074 (remove Node.js 4 from cordova-ios package.json & CI) is committed it is time to:
> * remove {{bundledDependencies}} entry from {{package.json}}
> * remove the committed {{node_modules}}
> * fix {{.gitignore}} to completely ignore {{node_modules}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org