You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/22 03:59:50 UTC

[GitHub] [arrow] wjones127 opened a new pull request #9289: ARROW-11341: [Python] [Gandiva] Add NULL/None checks to Gandiva builder functions

wjones127 opened a new pull request #9289:
URL: https://github.com/apache/arrow/pull/9289


   If these functions were passed None as an argument, they caused segfaults. As an example:
   
   ```python
   import pyarrow
   import pyarrow.gandiva as gandiva
   
   builder = gandiva.TreeExprBuilder()
   field = pyarrow.field('whatever', type=pyarrow.date64())
   date_col = builder.make_field(field)
   
   func = builder.make_function('less_than_or_equal_to', [date_col, None], pyarrow.bool_())
   
   condition = builder.make_condition(func)
   
   # Will segfault on this line:
   gandiva.make_filter(pyarrow.schema([field]), condition)
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] wjones127 commented on pull request #9289: ARROW-11341: [Python] [Gandiva] Add NULL/None checks to Gandiva builder functions

Posted by GitBox <gi...@apache.org>.
wjones127 commented on pull request #9289:
URL: https://github.com/apache/arrow/pull/9289#issuecomment-886244817


   @jorisvandenbossche Would you have time to review and/or merge?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #9289: ARROW-11341: [Python] [Gandiva] Add NULL/None checks to Gandiva builder functions

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9289:
URL: https://github.com/apache/arrow/pull/9289#issuecomment-765105119


   https://issues.apache.org/jira/browse/ARROW-11341


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] wjones127 commented on pull request #9289: ARROW-11341: [Python] [Gandiva] Add NULL/None checks to Gandiva builder functions

Posted by GitBox <gi...@apache.org>.
wjones127 commented on pull request #9289:
URL: https://github.com/apache/arrow/pull/9289#issuecomment-810417521


   Good call on the tests. Looks like we are still getting a segfault. I will look into that later today.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] wjones127 commented on pull request #9289: ARROW-11341: [Python] [Gandiva] Add NULL/None checks to Gandiva builder functions

Posted by GitBox <gi...@apache.org>.
wjones127 commented on pull request #9289:
URL: https://github.com/apache/arrow/pull/9289#issuecomment-811583991


   @projjal Should be good to review now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #9289: ARROW-11341: [Python] [Gandiva] Add NULL/None checks to Gandiva builder functions

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9289:
URL: https://github.com/apache/arrow/pull/9289#issuecomment-765105119


   https://issues.apache.org/jira/browse/ARROW-11341


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] wjones127 commented on pull request #9289: ARROW-11341: [Python] [Gandiva] Add NULL/None checks to Gandiva builder functions

Posted by GitBox <gi...@apache.org>.
wjones127 commented on pull request #9289:
URL: https://github.com/apache/arrow/pull/9289#issuecomment-1034014284


   Had this sitting around, but would still like to get this done. Just rebased, @jorisvandenbossche would you mind reviewing?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org