[jira] [Commented] (OFBIZ-8321) Labels cache clearing no longer works

["Jacques Le Roux (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-8321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15561839#comment-15561839 ] 

Jacques Le Roux commented on OFBIZ-8321:
----------------------------------------

This is related with OFBIZ-7937. A simple solution is to exclude all labels files. I propose this, there should not be any *Labels*.xml in config dirs which would not be a labels files.

{code}
Index: build.gradle
===================================================================
--- build.gradle	(revision 1763752)
+++ build.gradle	(working copy)
@@ -192,6 +192,15 @@
 excludedJavaSources.add 'org/apache/ofbiz/order/thirdparty/taxware/TaxwareServices.java'
 excludedJavaSources.add 'org/apache/ofbiz/order/thirdparty/taxware/TaxwareUTL.java'

+def excludedLabelsFiles = []
+excludedLabelsFiles.add '*Labels*.xml'
+excludedLabelsFiles.add 'conditional.xml'
+excludedLabelsFiles.add 'DefaultMessages.xml'
+excludedLabelsFiles.add 'EmailPassword.xml'
+
+
+
+
 sourceSets {
     main {
         java {
@@ -203,6 +212,7 @@
             srcDirs += getDirectoryInActiveComponentsIfExists('config')
             srcDirs += getDirectoryInActiveComponentsIfExists('dtd')
             exclude excludedJavaSources
+            exclude excludedLabelsFiles
         }
     }
{code}

BTW It seems to me it would be better to rename
conditional.xml to conditionalLabels.xml
DefaultMessages.xml to DefaultMessagesLabels.xml
EmailPassword.xml to EmailPasswordLabels.xml
I'd do so in few days if nobody disagree


Also Pierre already proposed at OFBIZ-7893 to exclude:
+    exclude ('*.xml')
+    exclude ('*.txt')
+    exclude ('*.jks')
+    exclude ('README')

I see really no reason to not exclude text and readme files. For *.xml I'd be more cautious, for instance what about axis2.xml and DefaultBarcode.xml? Are they usefull in ofbiz.jar? It seems not to me but would be better to check, and not only those.

For *.jks I guess it's ok to exclude, I'll anyway check this when I'll implement OFBIZ-7928 which should be hopefully soon.

I like to be able to dynamically changes properties by clearing their cache. So I'd also exclude them, but we need to check if nothing would break. For instance the properties files in framework/start/src/main/java/org/apache/ofbiz/base/start should not be excluded I guess. For the others I see no reasons to not exclude.

I'm also curious about why
srcDirs += getDirectoryInActiveComponentsIfExists('dtd')
was added in http://svn.apache.org/viewvc?view=revision&revision=1761440.
I guess for a good reason, and anyway it's not a big deal (apart bloating ofbiz.jar) since I see no reasons to dynamically changes these files while running OFBiz, so more curious than anything else here.



> Labels cache clearing no longer works
> -------------------------------------
>
>                 Key: OFBIZ-8321
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-8321
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL APPLICATIONS
>    Affects Versions: Trunk
>            Reporter: Jacques Le Roux
>             Fix For: Upcoming Branch
>
>
> While working on OFBIZ-7798 I noticed an issue with labels cache clearing. It still works correctly in R15.12, I did not test between.
> To test it, load a page with a label, change the label in file, clear all caches in webtools, the new label value should appear, it does not.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)