You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Roy van Rijn (JIRA)" <ji...@apache.org> on 2008/04/09 19:41:25 UTC
[jira] Created: (WICKET-1506) More Generics
(IBookmarkablePageRequestTarget)
More Generics (IBookmarkablePageRequestTarget)
----------------------------------------------
Key: WICKET-1506
URL: https://issues.apache.org/jira/browse/WICKET-1506
Project: Wicket
Issue Type: Wish
Components: wicket
Affects Versions: 1.4-M1
Reporter: Roy van Rijn
Priority: Trivial
With the current movement to Java 5 some more generics can be added.
For example:
IBookmarkablePageRequestTarget.getPageClass could return Class<? extends Page> instead of just Class. This all helps the users and removes some casts.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1506) More Generics
(IBookmarkablePageRequestTarget)
Posted by "Roy van Rijn (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12587514#action_12587514 ]
Roy van Rijn commented on WICKET-1506:
--------------------------------------
Heh, I will when I get the time, hopefully this weekend, maybe even tonight.
> More Generics (IBookmarkablePageRequestTarget)
> ----------------------------------------------
>
> Key: WICKET-1506
> URL: https://issues.apache.org/jira/browse/WICKET-1506
> Project: Wicket
> Issue Type: Wish
> Components: wicket
> Affects Versions: 1.4-M1
> Reporter: Roy van Rijn
> Priority: Trivial
> Original Estimate: 0.08h
> Remaining Estimate: 0.08h
>
> With the current movement to Java 5 some more generics can be added.
> For example:
> IBookmarkablePageRequestTarget.getPageClass could return Class<? extends Page> instead of just Class. This all helps the users and removes some casts.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1506) More Generics
(IBookmarkablePageRequestTarget)
Posted by "Roy van Rijn (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roy van Rijn updated WICKET-1506:
---------------------------------
Remaining Estimate: (was: 0.08h)
Original Estimate: (was: 0.08h)
> More Generics (IBookmarkablePageRequestTarget)
> ----------------------------------------------
>
> Key: WICKET-1506
> URL: https://issues.apache.org/jira/browse/WICKET-1506
> Project: Wicket
> Issue Type: Wish
> Components: wicket
> Affects Versions: 1.4-M1
> Reporter: Roy van Rijn
> Priority: Trivial
> Attachments: classextendspage_patch.txt
>
>
> With the current movement to Java 5 some more generics can be added.
> For example:
> IBookmarkablePageRequestTarget.getPageClass could return Class<? extends Page> instead of just Class. This all helps the users and removes some casts.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1506) More Generics
(IBookmarkablePageRequestTarget)
Posted by "Roy van Rijn (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12587281#action_12587281 ]
Roy van Rijn commented on WICKET-1506:
--------------------------------------
The same thing goes for:
Class<? extends Page> WebApplication.getHomePage()
And maybe some static String could be changed into enums? For example WebApplication.getConfigurationType(), only limited String alowed there, enums could make the code a bit safer.
> More Generics (IBookmarkablePageRequestTarget)
> ----------------------------------------------
>
> Key: WICKET-1506
> URL: https://issues.apache.org/jira/browse/WICKET-1506
> Project: Wicket
> Issue Type: Wish
> Components: wicket
> Affects Versions: 1.4-M1
> Reporter: Roy van Rijn
> Priority: Trivial
> Original Estimate: 0.08h
> Remaining Estimate: 0.08h
>
> With the current movement to Java 5 some more generics can be added.
> For example:
> IBookmarkablePageRequestTarget.getPageClass could return Class<? extends Page> instead of just Class. This all helps the users and removes some casts.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (WICKET-1506) More Generics
(IBookmarkablePageRequestTarget)
Posted by "Johan Compagner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Johan Compagner closed WICKET-1506.
-----------------------------------
Resolution: Fixed
Fix Version/s: 1.4-M1
Assignee: Johan Compagner
applied
> More Generics (IBookmarkablePageRequestTarget)
> ----------------------------------------------
>
> Key: WICKET-1506
> URL: https://issues.apache.org/jira/browse/WICKET-1506
> Project: Wicket
> Issue Type: Wish
> Components: wicket
> Affects Versions: 1.4-M1
> Reporter: Roy van Rijn
> Assignee: Johan Compagner
> Priority: Trivial
> Fix For: 1.4-M1
>
> Attachments: classextendspage_patch.txt
>
>
> With the current movement to Java 5 some more generics can be added.
> For example:
> IBookmarkablePageRequestTarget.getPageClass could return Class<? extends Page> instead of just Class. This all helps the users and removes some casts.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1506) More Generics
(IBookmarkablePageRequestTarget)
Posted by "Johan Compagner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12587283#action_12587283 ]
Johan Compagner commented on WICKET-1506:
-----------------------------------------
make patches!
Not all generics are done yet!
it was just the first cut
> More Generics (IBookmarkablePageRequestTarget)
> ----------------------------------------------
>
> Key: WICKET-1506
> URL: https://issues.apache.org/jira/browse/WICKET-1506
> Project: Wicket
> Issue Type: Wish
> Components: wicket
> Affects Versions: 1.4-M1
> Reporter: Roy van Rijn
> Priority: Trivial
> Original Estimate: 0.08h
> Remaining Estimate: 0.08h
>
> With the current movement to Java 5 some more generics can be added.
> For example:
> IBookmarkablePageRequestTarget.getPageClass could return Class<? extends Page> instead of just Class. This all helps the users and removes some casts.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1506) More Generics
(IBookmarkablePageRequestTarget)
Posted by "Roy van Rijn (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roy van Rijn updated WICKET-1506:
---------------------------------
Attachment: classextendspage_patch.txt
Added a patch for adding Class<? extends Page> to:
getPageClass functions
getHomePage functions
getLoginPage functions
(my first patch, is it ok?)
> More Generics (IBookmarkablePageRequestTarget)
> ----------------------------------------------
>
> Key: WICKET-1506
> URL: https://issues.apache.org/jira/browse/WICKET-1506
> Project: Wicket
> Issue Type: Wish
> Components: wicket
> Affects Versions: 1.4-M1
> Reporter: Roy van Rijn
> Priority: Trivial
> Attachments: classextendspage_patch.txt
>
> Original Estimate: 0.08h
> Remaining Estimate: 0.08h
>
> With the current movement to Java 5 some more generics can be added.
> For example:
> IBookmarkablePageRequestTarget.getPageClass could return Class<? extends Page> instead of just Class. This all helps the users and removes some casts.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.