[GitHub] [incubator-kyuubi] ulysses-you commented on a change in pull request #993: [KYUUBI #991][FOLLOWUP] Improve error msg and add SPARK_HOME in Examples

[GitBox <gi...@apache.org>]

ulysses-you commented on a change in pull request #993:
URL: https://github.com/apache/incubator-kyuubi/pull/993#discussion_r697205879



##########
File path: kyuubi-server/src/main/scala/org/apache/kyuubi/engine/spark/SparkProcessBuilder.scala
##########
@@ -58,7 +58,9 @@ class SparkProcessBuilder(
     sparkHomeOpt.map{ dir =>
       Paths.get(dir, "bin", SPARK_SUBMIT_FILE).toAbsolutePath.toFile.getCanonicalPath
     }.getOrElse {
-      throw KyuubiSQLException("SPARK_HOME is not set!")
+      throw KyuubiSQLException("SPARK_HOME is not set! " +
+        "For more detail information on installing and configuring Spark, please visit " +
+        "https://kyuubi.apache.org/docs/stable/deployment/index.html")

Review comment:
       refer the docs is good idea. how about use the more accurate url: `https://kyuubi.apache.org/docs/stable/deployment/settings.html#environments`.
   And seems we should also update the docs.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org