You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/04/11 10:06:25 UTC
[jira] [Commented] (CB-11062) Cloning git repo when installing a
plugin doesn't fetch submodules
[ https://issues.apache.org/jira/browse/CB-11062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15234656#comment-15234656 ]
ASF GitHub Bot commented on CB-11062:
-------------------------------------
GitHub user jfrumar opened a pull request:
https://github.com/apache/cordova-lib/pull/424
[CB-11062] Add --recursive option to git clone command
Support cordova plugins that make use of git submodules.
ref: https://issues.apache.org/jira/browse/CB-11062
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jfrumar/cordova-lib master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/424.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #424
----
commit f33b695e32d3d9d89fb697a0fc38da5c61ce2db7
Author: Julian Frumar <jf...@users.noreply.github.com>
Date: 2016-04-11T06:34:07Z
Add --recursive option to git clone command
----
> Cloning git repo when installing a plugin doesn't fetch submodules
> ------------------------------------------------------------------
>
> Key: CB-11062
> URL: https://issues.apache.org/jira/browse/CB-11062
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib, Plugman
> Affects Versions: 6.1.1
> Reporter: Julian Frumar
>
> When installing a plugin using a git repo as the id, e.g:
> {code}cordova plugin install https://github.com/path_to_git_repo.git{code}
> The plugman helper [gitclone.js|https://github.com/apache/cordova-lib/blob/master/cordova-lib%2Fsrc%2Fgitclone.js] doesn't retrieve using the *--recursive* option, so submodules are not fetched.
> This is breaking our plugin as cordova is failing to find all the necessary files as specified in the plugin.xml (some of them are from a nested git submodule repo)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org