You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/03/13 17:36:53 UTC
[GitHub] [incubator-nuttx-apps] patacongo opened a new pull request #121:
apps/system/cle: Fix error when compiling with C89 compiler.
patacongo opened a new pull request #121: apps/system/cle: Fix error when compiling with C89 compiler.
URL: https://github.com/apache/incubator-nuttx-apps/pull/121
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in
pull request #121: apps/system/cle: Fix error when compiling with C89
compiler.
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #121: apps/system/cle: Fix error when compiling with C89 compiler.
URL: https://github.com/apache/incubator-nuttx-apps/pull/121#discussion_r392612610
##########
File path: system/cle/cle.c
##########
@@ -798,6 +799,9 @@ static int cle_editloop(FAR struct cle_s *priv)
for (; ; )
{
+#if 1 /* Perhaps here should be a config switch */
Review comment:
But @patacongo why we add #if/#endif?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] Ouss4 commented on a change in pull request
#121: apps/system/cle: Fix error when compiling with C89 compiler.
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on a change in pull request #121: apps/system/cle: Fix error when compiling with C89 compiler.
URL: https://github.com/apache/incubator-nuttx-apps/pull/121#discussion_r392419781
##########
File path: system/cle/cle.c
##########
@@ -798,6 +799,9 @@ static int cle_editloop(FAR struct cle_s *priv)
for (; ; )
{
+#if 1 /* Perhaps here should be a config switch */
Review comment:
Do you want to keep the PR open, or should it be merged?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] patacongo commented on a change in pull
request #121: apps/system/cle: Fix error when compiling with C89 compiler.
Posted by GitBox <gi...@apache.org>.
patacongo commented on a change in pull request #121: apps/system/cle: Fix error when compiling with C89 compiler.
URL: https://github.com/apache/incubator-nuttx-apps/pull/121#discussion_r392616489
##########
File path: system/cle/cle.c
##########
@@ -798,6 +799,9 @@ static int cle_editloop(FAR struct cle_s *priv)
for (; ; )
{
+#if 1 /* Perhaps here should be a config switch */
Review comment:
It was added. It was already there. Just copied. The original authored intended to add a configuration option but left #if1 in place of the missing option.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] patacongo commented on issue #121:
apps/system/cle: Fix error when compiling with C89 compiler.
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #121: apps/system/cle: Fix error when compiling with C89 compiler.
URL: https://github.com/apache/incubator-nuttx-apps/pull/121#issuecomment-598873340
I believe it should be merged. It jsut moves a local variable from the middle of a function to the top as required by C89. Without this, NSH with the CLE fails to build with the ZDS-II toolchain.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] Ouss4 merged pull request #121:
apps/system/cle: Fix error when compiling with C89 compiler.
Posted by GitBox <gi...@apache.org>.
Ouss4 merged pull request #121: apps/system/cle: Fix error when compiling with C89 compiler.
URL: https://github.com/apache/incubator-nuttx-apps/pull/121
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] patacongo commented on a change in pull
request #121: apps/system/cle: Fix error when compiling with C89 compiler.
Posted by GitBox <gi...@apache.org>.
patacongo commented on a change in pull request #121: apps/system/cle: Fix error when compiling with C89 compiler.
URL: https://github.com/apache/incubator-nuttx-apps/pull/121#discussion_r392616489
##########
File path: system/cle/cle.c
##########
@@ -798,6 +799,9 @@ static int cle_editloop(FAR struct cle_s *priv)
for (; ; )
{
+#if 1 /* Perhaps here should be a config switch */
Review comment:
It was NOT added. It was already there. Just copied from its original location. The original author intended to add a configuration option but left #if1 in place of the missing option.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] Ouss4 commented on a change in pull request
#121: apps/system/cle: Fix error when compiling with C89 compiler.
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on a change in pull request #121: apps/system/cle: Fix error when compiling with C89 compiler.
URL: https://github.com/apache/incubator-nuttx-apps/pull/121#discussion_r392419781
##########
File path: system/cle/cle.c
##########
@@ -798,6 +799,9 @@ static int cle_editloop(FAR struct cle_s *priv)
for (; ; )
{
+#if 1 /* Perhaps here should be a config switch */
Review comment:
Do you want to keep the PR open or should it be merged?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services