You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "liuxiaocs7 (via GitHub)" <gi...@apache.org> on 2026/08/25 18:50:21 UTC
[I] fix(desktop): daily-review active-task rows overflow the clamped column and clip their timestamps [maka]
liuxiaocs7 opened a new issue, #3830:
URL: https://github.com/apache/maka/issues/3830
## What happened
On the desktop **每日回顾 / Daily Review** tab, rows in the **活跃任务 / active conversations** list overflow the clamped page column. When a session's `lastMessagePreview` is long, the row stretches far past the ~900px content column, so the trailing timestamp (and, at the same time, the 费用 / cost metric in the totals strip) is pushed off the right edge and clipped by the Layout's `overflow: hidden`.
Expected: the row shrinks to the column width and the preview truncates with an ellipsis, keeping the trailing timestamp visible — the way sibling module lists (e.g. 定时任务) already behave.
## How to reproduce
1. Open the desktop app → 定时任务 → **每日回顾** tab (or Settings → Daily Review).
2. Have (or generate) an active conversation whose last-message preview is a long, single run of text.
3. Observe the active-task row: the preview runs to the right edge and the relative-time label on the right is clipped.
Reproduced deterministically against the real Storybook DOM (`product-module-hubs--host-automations-daily-review`) by injecting a long preview at a 1400px viewport: the content column stays 860px while the `List`/rows balloon to 1502px, and the timestamp's right edge lands at 1762 vs the column edge at 1128.
## Root cause
`.maka-daily-review-content` (`apps/desktop/src/renderer/styles/daily-review.css`) is `display: grid` with **no** explicit `grid-template-columns`, so it uses an implicit `auto` track. The row preview is a single `white-space: nowrap` line, so its max-content width is the full untruncated string; the `auto` track sizes to that max-content and the rows overflow the clamped column instead of shrinking/truncating.
Sibling lists avoid this because their `List` sits directly in `.maka-module-page-panel`, which already carries the `grid-template-columns: minmax(0, 1fr)` guard. Daily Review nests the list one grid layer deeper, and that inner grid lacked the same guard.
## Environment
- Maka commit: d2754b1ee
- OS and version: macOS (Darwin 24.6.0)
- Surface: Desktop
- Node.js version: 24.14.0
## Logs, screenshots, or additional context
Measured before/after applying `grid-template-columns: minmax(0, 1fr)` to `.maka-daily-review-content`:
| | List width | Timestamp right edge | Column right edge | Overflow |
|---|---|---|---|---|
| Before | 1502px | 1762 | 1128 | yes |
| After | 860px | 1120 | 1128 | no |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [I] daily-review active-task rows overflow the clamped column and clip their timestamps [maka]
Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han closed issue #3830: daily-review active-task rows overflow the clamped column and clip their timestamps
URL: https://github.com/apache/maka/issues/3830
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org