You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tubemq.apache.org by "viviel (Jira)" <ji...@apache.org> on 2020/05/21 02:45:00 UTC
[jira] [Commented] (TUBEMQ-139) a bug in the equals method of the
TubeClientConfig class
[ https://issues.apache.org/jira/browse/TUBEMQ-139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17112738#comment-17112738 ]
viviel commented on TUBEMQ-139:
-------------------------------
I think there are two places that can be optimized:
1. Use the equals generation tool that comes with idea to generate, which can reduce the probability of errors.
2. Override hashCode method.
If there is no problem, I can change it according to the two points above.
> a bug in the equals method of the TubeClientConfig class
> --------------------------------------------------------
>
> Key: TUBEMQ-139
> URL: https://issues.apache.org/jira/browse/TUBEMQ-139
> Project: Apache TubeMQ
> Issue Type: Bug
> Reporter: Guocheng Zhang
> Assignee: Guocheng Zhang
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.5.0
>
> Attachments: image-2020-05-21-10-27-25-938.png, image-2020-05-21-10-28-10-332.png
>
>
> There is a bug in the equals method of the TubeClientConfig class:
> !image-2020-05-21-10-27-25-938.png!
> it should be:
> !image-2020-05-21-10-28-10-332.png!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)