[GitHub] [pinot] walterddr commented on a diff in pull request #10408: [multistage] Implement ordering for SortExchange

["walterddr (via GitHub)" <gi...@apache.org>]

walterddr commented on code in PR #10408:
URL: https://github.com/apache/pinot/pull/10408#discussion_r1134905153


##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/stage/MailboxReceiveNode.java:
##########
@@ -43,11 +57,25 @@ public MailboxReceiveNode(int stageId) {
 
   public MailboxReceiveNode(int stageId, DataSchema dataSchema, int senderStageId,
       RelDistribution.Type exchangeType, @Nullable KeySelector<Object[], Object[]> partitionKeySelector,
+      @Nullable List<RelFieldCollation> fieldCollations, boolean isInputSorted, boolean sortOnReceiver,

Review Comment:
   +1 but i dont think this PR would be related since the refactoring only deal with visitor invariant, shared info across the stage such as partition, stageID, etc. 
   
   but i would anticipate a rebase issue. thank you for calling it out @ankitsultana 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org