You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/05/15 02:54:43 UTC
[GitHub] [pulsar] yangl opened a new pull request #10597: Fix pulsar-client & pulsar-client-admin shaded jar missing code source
yangl opened a new pull request #10597:
URL: https://github.com/apache/pulsar/pull/10597
### Motivation
when we use the `pulsar-client` and the `pulsar-client-admin` dependency in the ide(such as the IntelliJ IDEA), which cannot link the code source correctly because of the both jar was shaded by the maven-shade-plugin.
### Modifications
1. add the `<createSourcesJar>true</createSourcesJar>` configuration in the [maven-shade-plugin.](https://maven.apache.org/plugins/maven-shade-plugin/shade-mojo.html#createSourcesJar)
2. change the maven-source-plugin execution phase to `package`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yangl commented on pull request #10597: Fix pulsar-client & pulsar-client-admin shaded jar missing code source
Posted by GitBox <gi...@apache.org>.
yangl commented on pull request #10597:
URL: https://github.com/apache/pulsar/pull/10597#issuecomment-866788149
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yangl removed a comment on pull request #10597: Fix pulsar-client & pulsar-client-admin shaded jar missing code source
Posted by GitBox <gi...@apache.org>.
yangl removed a comment on pull request #10597:
URL: https://github.com/apache/pulsar/pull/10597#issuecomment-841623062
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yangl commented on pull request #10597: Fix pulsar-client & pulsar-client-admin shaded jar missing code source
Posted by GitBox <gi...@apache.org>.
yangl commented on pull request #10597:
URL: https://github.com/apache/pulsar/pull/10597#issuecomment-867262753
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yangl closed pull request #10597: Fix pulsar-client & pulsar-client-admin shaded jar missing code source
Posted by GitBox <gi...@apache.org>.
yangl closed pull request #10597:
URL: https://github.com/apache/pulsar/pull/10597
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yangl commented on pull request #10597: Fix pulsar-client & pulsar-client-admin shaded jar missing code source
Posted by GitBox <gi...@apache.org>.
yangl commented on pull request #10597:
URL: https://github.com/apache/pulsar/pull/10597#issuecomment-841623062
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat commented on pull request #10597: Fix pulsar-client & pulsar-client-admin shaded jar missing code source
Posted by GitBox <gi...@apache.org>.
merlimat commented on pull request #10597:
URL: https://github.com/apache/pulsar/pull/10597#issuecomment-841662407
@yangl I think this got broken in #8962. The problem is that the shading profile must not include `pulsar-client-api`. Instead that is meant to be left as an unshaded transitive dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org