You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/10/19 01:30:27 UTC
[GitHub] [shardingsphere-elasticjob] gzdzss opened a new pull request #1590: Remove real token from error handler test cases
gzdzss opened a new pull request #1590:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1590
For #1574.
Changes proposed in this pull request:
- Remove real token from error handler test cases
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] codecov-io commented on pull request #1590: Remove real token from error handler test cases
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1590:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1590#issuecomment-711462966
# [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1590?src=pr&el=h1) Report
> Merging [#1590](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1590?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere-elasticjob/commit/0de4f7a32b246129a49ce899a640a249dc309772?el=desc) will **decrease** coverage by `0.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1590?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1590 +/- ##
============================================
- Coverage 85.55% 85.40% -0.15%
Complexity 102 102
============================================
Files 250 250
Lines 5668 5668
Branches 875 875
============================================
- Hits 4849 4841 -8
- Misses 506 514 +8
Partials 313 313
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1590?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...e/shardingsphere/elasticjob/infra/env/IpUtils.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1590/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLWluZnJhLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9pbmZyYS9lbnYvSXBVdGlscy5qYXZh) | `60.00% <0.00%> (-4.62%)` | `0.00% <0.00%> (ø%)` | |
| [...ite/internal/election/ElectionListenerManager.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1590/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvZWxlY3Rpb24vRWxlY3Rpb25MaXN0ZW5lck1hbmFnZXIuamF2YQ==) | `92.00% <0.00%> (-4.00%)` | `0.00% <0.00%> (ø%)` | |
| [...asticjob/lite/internal/storage/JobNodeStorage.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1590/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc3RvcmFnZS9Kb2JOb2RlU3RvcmFnZS5qYXZh) | `87.50% <0.00%> (-3.58%)` | `0.00% <0.00%> (ø%)` | |
| [...ticjob/lite/internal/snapshot/SnapshotService.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1590/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc25hcHNob3QvU25hcHNob3RTZXJ2aWNlLmphdmE=) | `77.77% <0.00%> (-3.18%)` | `1.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1590?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1590?src=pr&el=footer). Last update [0de4f7a...949a551](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1590?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] codecov-io edited a comment on pull request #1590: Remove real token from error handler test cases
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1590:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1590#issuecomment-711462966
# [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1590?src=pr&el=h1) Report
> Merging [#1590](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1590?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere-elasticjob/commit/0de4f7a32b246129a49ce899a640a249dc309772?el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1590?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1590 +/- ##
============================================
+ Coverage 85.55% 85.56% +0.01%
Complexity 102 102
============================================
Files 250 250
Lines 5668 5668
Branches 875 875
============================================
+ Hits 4849 4850 +1
Misses 506 506
+ Partials 313 312 -1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1590?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ticjob/lite/internal/snapshot/SnapshotService.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1590/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc25hcHNob3QvU25hcHNob3RTZXJ2aWNlLmphdmE=) | `82.53% <0.00%> (+1.58%)` | `1.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1590?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1590?src=pr&el=footer). Last update [0de4f7a...949a551](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1590?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] terrymanu merged pull request #1590: Remove real token from error handler test cases
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #1590:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1590
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org