[GitHub] [beam] lukecwik commented on a change in pull request #12634: [BEAM-10761] Prefer TestPubsub#assertSubscriptionEventuallyExists when waiting to inject data

[GitBox <gi...@apache.org>]

lukecwik commented on a change in pull request #12634:
URL: https://github.com/apache/beam/pull/12634#discussion_r474996332



##########
File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/TestPubsub.java
##########
@@ -273,11 +275,30 @@ public PollingAssertion assertThatTopicEventuallyReceives(Matcher<PubsubMessage>
   /**
    * Check if topics exist.
    *
+   * <p>{@Deprecated prefer {@link #assertSubscriptionEventuallyCreated}}.
+   *
    * @param project GCP project identifier.
    * @param timeoutDuration Joda duration that sets a period of time before checking times out.

Review comment:
       ```suggestion
      * @param project GCP project identifier.
      * @param timeoutDuration Joda duration that sets a period of time before checking times out.
      * @deprecated Use {@link #assertSubscriptionEventuallyCreated}.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org