You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/01/14 14:13:04 UTC

[GitHub] [superset] kgabryje commented on a change in pull request #18027: [WIP] fix(generator): more cleanup to plugin framework

kgabryje commented on a change in pull request #18027:
URL: https://github.com/apache/superset/pull/18027#discussion_r784873708



##########
File path: superset-frontend/webpack.config.js
##########
@@ -285,7 +285,9 @@ const config = {
     // resolve modules from `/superset_frontend/node_modules` and `/superset_frontend`
     modules: ['node_modules', APP_DIR],
     alias: {
-      // TODO: remove alias once React has been upgraaded to v. 17
+      // TODO: remove aliases once React has been upgraaded to v. 17 and

Review comment:
       ```suggestion
         // TODO: remove aliases once React has been upgraded to v. 17 and
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org