[GitHub] [helix] i3wangyi commented on issue #576: Minor log optimization for easily investigating mastership handoff latency

[GitBox <gi...@apache.org>]

i3wangyi commented on issue #576: Minor log optimization for easily investigating mastership handoff latency
URL: https://github.com/apache/helix/pull/576#issuecomment-551366956
 
 
   > I don't have a strong preference here. But we tend to be conservative on adding new logs. This has been complained about by our customers before.
   > So,
   > 
   > 1. If this is for debug, will log.debug be enough?
   > 2. If the concerning part is listener reset, shall we directly log the latency of the reset inside that method?
   
   I added 1 line at the (leader -> standby) relinquish stage.
   The other log changes are just either 1. move the log position 2. add the time duration. I don't think overall it will make the current log situation worse. 
   
   The purpose of the changes will help us quickly figure out the latency issue while searching the logs; Compared with the current approach: grep through logs and connecting dots here and there. Right?
   
   Too many logs is a problem in Helix controller; As a side project to this, I hope I will have some time to analyze the current logs and find things that can be discarded.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org