You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by huangyiminghappy <gi...@git.apache.org> on 2017/06/07 03:07:21 UTC
[GitHub] incubator-rocketmq pull request #104: Remove spaces before and after the pro...
Github user huangyiminghappy commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/104#discussion_r117210642
--- Diff: common/src/main/java/org/apache/rocketmq/common/MixAll.java ---
@@ -339,6 +339,8 @@ public static void properties2Object(final Properties p, final Object object) {
String key = first.toLowerCase() + tmp;
String property = p.getProperty(key);
if (property != null) {
+ // remove spaces before and after
--- End diff --
yes ,you are right,wo can add trim like this:
Add directly in properties2String is not accurate,because attribute and value also may before or after blank,i commit and pull request ,please review it ,thank you
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---