You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2021/12/31 06:52:38 UTC

[GitHub] [incubator-seatunnel] leo65535 edited a comment on pull request #906: [SeaTunnel #904] [config] improve the config parse logic

leo65535 edited a comment on pull request #906:
URL: https://github.com/apache/incubator-seatunnel/pull/906#issuecomment-1003287966


   Hi @RickyHuo @garyelephant @CalvinKirs @simon824, I implemented the second version, please review the patch when you are free, thanks.
   
   1. Add `SeaTunnelConfigFactory` which works as `ConfigFactory`.
   2. Extract the sort logic to `SeaTunnelConfigParser`(Keep it the same as before)
   
   ![image](https://user-images.githubusercontent.com/95013770/147808262-d14bc2fc-cdec-4564-9e71-8c736018c3b2.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org