You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by chenghao-intel <gi...@git.apache.org> on 2015/04/02 08:19:28 UTC
[GitHub] spark pull request: [SPARK-3862] [SQL] [WIP] MultiWayBroadcastJoin...
GitHub user chenghao-intel opened a pull request:
https://github.com/apache/spark/pull/5326
[SPARK-3862] [SQL] [WIP] MultiWayBroadcastJoin for LeftSemi & Inner JOIN
Assume we have table `x`, `y`, `z`, and the `x` is the fact table with large mount of data, and `y`, `z` are dimensional tables.
```sql
SELECT x.a, y.a, z.a FROM x JOIN y ON x.a = y.a AND y.a < 3 JOIN z ON x.a = z.a AND z.a > 1
```
To compute the result, it's required multiple times reading / writing data for fact table(large amount of data) if we do that as binary join way; this PR (multiple way broadcast join) will reduce the IO overhead significantly by reading all of the data once, as well as the filtering effect of the multiple join filters.
This PR is for earlier feedbacks, some TODOs as below, but probably can be done in another PRs
- Multiway-join for JOINs in identical equi-join.
- Join Reordering.
- Integrated with Sort-Merge-Join in Multiway JOIN.
- Code Clean Up, to unify the JOIN code by removing the binary join(replaced with multiple way join)
Restrictions
- The fact table should be in the left-most, we can improve that in `Join Reordering`.
Benchmarking result will be provided soon...
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chenghao-intel/spark dim_join
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/5326.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5326
----
commit 84d15d50693fbea35c11963484ef8cd798e7bd55
Author: Cheng Hao <ha...@intel.com>
Date: 2015-03-26T03:01:21Z
minor changes
commit 645b9bee819501e7aec8d2ae1b29812a857d9fde
Author: Cheng Hao <ha...@intel.com>
Date: 2015-03-26T04:17:57Z
update the code of empty check in HashedRelation related code
commit 90fa2858351d6e774a48f3502bd58f6eafa96dad
Author: Cheng Hao <ha...@intel.com>
Date: 2015-03-25T08:15:01Z
Add multiple row & multi-way join support
commit aa4bab2530e64fd0b51001de10176b7fa182e222
Author: Cheng Hao <ha...@intel.com>
Date: 2015-04-01T06:17:57Z
WIP broadcast join
commit b4cbabdb541192ea0e8864627ea8d3b25523e5b3
Author: Cheng Hao <ha...@intel.com>
Date: 2015-04-02T05:48:13Z
star schema
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3862] [SQL] [WIP] MultiWayBroadcastJoin...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5326#issuecomment-89213658
[Test build #29650 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29650/consoleFull) for PR 5326 at commit [`e62be3b`](https://github.com/apache/spark/commit/e62be3bb17361be01e3a238c74bc86fa4bb3dae3).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `case class DimensionJoin(`
* `case class JoinFilter(joinType: JoinType, filter: Expression)`
* `case class JoinKey(leftKeys: Seq[Expression], rightKeys: Seq[Expression])`
* `trait CompactBufferBuilder extends java.io.Serializable `
* `class IteratorBufferBuilder extends CompactBufferBuilder `
* `class HashedBufferBuilder(relation: HashedRelation) extends CompactBufferBuilder `
* `class CorrelatedBufferBuilder(key: Projection, relation: HashedRelation)`
* `class ConstantBufferBuilder(row: Row) extends CompactBufferBuilder `
* `trait MultiwayJoin `
* ` class MultiBuild extends HashSet[Int] with BuildSide `
* This patch does not change any dependencies.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3862] [SQL] [WIP] MultiWayBroadcastJoin...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5326#issuecomment-88812193
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29595/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3862] [SQL] [WIP] MultiWayBroadcastJoin...
Posted by chenghao-intel <gi...@git.apache.org>.
Github user chenghao-intel closed the pull request at:
https://github.com/apache/spark/pull/5326
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3862] [SQL] [WIP] MultiWayBroadcastJoin...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5326#issuecomment-88771516
[Test build #29591 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29591/consoleFull) for PR 5326 at commit [`b4cbabd`](https://github.com/apache/spark/commit/b4cbabdb541192ea0e8864627ea8d3b25523e5b3).
* This patch **fails Scala style tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `case class DimensionJoin(`
* `case class JoinFilter(joinType: JoinType, filter: Expression)`
* `case class JoinKey(leftKeys: Seq[Expression], rightkeys: Seq[Expression])`
* `trait CompactBufferBuilder extends java.io.Serializable `
* `class IteratorBufferBuilder extends CompactBufferBuilder `
* `class HashedBufferBuilder(relation: HashedRelation) extends CompactBufferBuilder `
* `class CorrelatedBufferBuilder(key: Projection, relation: HashedRelation) extends CompactBufferBuilder `
* `class ConstantBufferBuilder(row: Row) extends CompactBufferBuilder `
* `trait MultiwayJoin `
* ` class MultiBuild extends HashSet[Int] with BuildSide `
* This patch **removes the following dependencies:**
* `RoaringBitmap-0.4.5.jar`
* `activation-1.1.jar`
* `akka-actor_2.10-2.3.4-spark.jar`
* `akka-remote_2.10-2.3.4-spark.jar`
* `akka-slf4j_2.10-2.3.4-spark.jar`
* `aopalliance-1.0.jar`
* `arpack_combined_all-0.1.jar`
* `avro-1.7.7.jar`
* `breeze-macros_2.10-0.11.2.jar`
* `breeze_2.10-0.11.2.jar`
* `chill-java-0.5.0.jar`
* `chill_2.10-0.5.0.jar`
* `commons-beanutils-1.7.0.jar`
* `commons-beanutils-core-1.8.0.jar`
* `commons-cli-1.2.jar`
* `commons-codec-1.10.jar`
* `commons-collections-3.2.1.jar`
* `commons-compress-1.4.1.jar`
* `commons-configuration-1.6.jar`
* `commons-digester-1.8.jar`
* `commons-httpclient-3.1.jar`
* `commons-io-2.1.jar`
* `commons-lang-2.5.jar`
* `commons-lang3-3.3.2.jar`
* `commons-math-2.1.jar`
* `commons-math3-3.1.1.jar`
* `commons-net-2.2.jar`
* `compress-lzf-1.0.0.jar`
* `config-1.2.1.jar`
* `core-1.1.2.jar`
* `curator-client-2.4.0.jar`
* `curator-framework-2.4.0.jar`
* `curator-recipes-2.4.0.jar`
* `gmbal-api-only-3.0.0-b023.jar`
* `grizzly-framework-2.1.2.jar`
* `grizzly-http-2.1.2.jar`
* `grizzly-http-server-2.1.2.jar`
* `grizzly-http-servlet-2.1.2.jar`
* `grizzly-rcm-2.1.2.jar`
* `groovy-all-2.3.7.jar`
* `guava-14.0.1.jar`
* `guice-3.0.jar`
* `hadoop-annotations-2.2.0.jar`
* `hadoop-auth-2.2.0.jar`
* `hadoop-client-2.2.0.jar`
* `hadoop-common-2.2.0.jar`
* `hadoop-hdfs-2.2.0.jar`
* `hadoop-mapreduce-client-app-2.2.0.jar`
* `hadoop-mapreduce-client-common-2.2.0.jar`
* `hadoop-mapreduce-client-core-2.2.0.jar`
* `hadoop-mapreduce-client-jobclient-2.2.0.jar`
* `hadoop-mapreduce-client-shuffle-2.2.0.jar`
* `hadoop-yarn-api-2.2.0.jar`
* `hadoop-yarn-client-2.2.0.jar`
* `hadoop-yarn-common-2.2.0.jar`
* `hadoop-yarn-server-common-2.2.0.jar`
* `ivy-2.4.0.jar`
* `jackson-annotations-2.4.0.jar`
* `jackson-core-2.4.4.jar`
* `jackson-core-asl-1.8.8.jar`
* `jackson-databind-2.4.4.jar`
* `jackson-jaxrs-1.8.8.jar`
* `jackson-mapper-asl-1.8.8.jar`
* `jackson-module-scala_2.10-2.4.4.jar`
* `jackson-xc-1.8.8.jar`
* `jansi-1.4.jar`
* `javax.inject-1.jar`
* `javax.servlet-3.0.0.v201112011016.jar`
* `javax.servlet-3.1.jar`
* `javax.servlet-api-3.0.1.jar`
* `jaxb-api-2.2.2.jar`
* `jaxb-impl-2.2.3-1.jar`
* `jcl-over-slf4j-1.7.10.jar`
* `jersey-client-1.9.jar`
* `jersey-core-1.9.jar`
* `jersey-grizzly2-1.9.jar`
* `jersey-guice-1.9.jar`
* `jersey-json-1.9.jar`
* `jersey-server-1.9.jar`
* `jersey-test-framework-core-1.9.jar`
* `jersey-test-framework-grizzly2-1.9.jar`
* `jets3t-0.7.1.jar`
* `jettison-1.1.jar`
* `jetty-util-6.1.26.jar`
* `jline-0.9.94.jar`
* `jline-2.10.4.jar`
* `jodd-core-3.6.3.jar`
* `json4s-ast_2.10-3.2.10.jar`
* `json4s-core_2.10-3.2.10.jar`
* `json4s-jackson_2.10-3.2.10.jar`
* `jsr305-1.3.9.jar`
* `jtransforms-2.4.0.jar`
* `jul-to-slf4j-1.7.10.jar`
* `kryo-2.21.jar`
* `log4j-1.2.17.jar`
* `lz4-1.2.0.jar`
* `management-api-3.0.0-b012.jar`
* `mesos-0.21.0-shaded-protobuf.jar`
* `metrics-core-3.1.0.jar`
* `metrics-graphite-3.1.0.jar`
* `metrics-json-3.1.0.jar`
* `metrics-jvm-3.1.0.jar`
* `minlog-1.2.jar`
* `netty-3.8.0.Final.jar`
* `netty-all-4.0.23.Final.jar`
* `objenesis-1.2.jar`
* `opencsv-2.3.jar`
* `oro-2.0.8.jar`
* `paranamer-2.6.jar`
* `parquet-column-1.6.0rc3.jar`
* `parquet-common-1.6.0rc3.jar`
* `parquet-encoding-1.6.0rc3.jar`
* `parquet-format-2.2.0-rc1.jar`
* `parquet-generator-1.6.0rc3.jar`
* `parquet-hadoop-1.6.0rc3.jar`
* `parquet-jackson-1.6.0rc3.jar`
* `protobuf-java-2.4.1.jar`
* `protobuf-java-2.5.0-spark.jar`
* `py4j-0.8.2.1.jar`
* `pyrolite-2.0.1.jar`
* `quasiquotes_2.10-2.0.1.jar`
* `reflectasm-1.07-shaded.jar`
* `scala-compiler-2.10.4.jar`
* `scala-library-2.10.4.jar`
* `scala-reflect-2.10.4.jar`
* `scalap-2.10.4.jar`
* `scalatest_2.10-2.2.1.jar`
* `slf4j-api-1.7.10.jar`
* `slf4j-log4j12-1.7.10.jar`
* `snappy-java-1.1.1.6.jar`
* `spark-bagel_2.10-1.4.0-SNAPSHOT.jar`
* `spark-catalyst_2.10-1.4.0-SNAPSHOT.jar`
* `spark-core_2.10-1.4.0-SNAPSHOT.jar`
* `spark-graphx_2.10-1.4.0-SNAPSHOT.jar`
* `spark-launcher_2.10-1.4.0-SNAPSHOT.jar`
* `spark-mllib_2.10-1.4.0-SNAPSHOT.jar`
* `spark-network-common_2.10-1.4.0-SNAPSHOT.jar`
* `spark-network-shuffle_2.10-1.4.0-SNAPSHOT.jar`
* `spark-repl_2.10-1.4.0-SNAPSHOT.jar`
* `spark-sql_2.10-1.4.0-SNAPSHOT.jar`
* `spark-streaming_2.10-1.4.0-SNAPSHOT.jar`
* `spire-macros_2.10-0.7.4.jar`
* `spire_2.10-0.7.4.jar`
* `stax-api-1.0.1.jar`
* `stream-2.7.0.jar`
* `tachyon-0.5.0.jar`
* `tachyon-client-0.5.0.jar`
* `uncommons-maths-1.2.2a.jar`
* `unused-1.0.0.jar`
* `xmlenc-0.52.jar`
* `xz-1.0.jar`
* `zookeeper-3.4.5.jar`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3862] [SQL] [WIP] MultiWayBroadcastJoin...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5326#issuecomment-88817225
[Test build #29596 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29596/consoleFull) for PR 5326 at commit [`987bbc3`](https://github.com/apache/spark/commit/987bbc3941528707e59be8aea0dcb568f9c7fd55).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `case class DimensionJoin(`
* `case class JoinFilter(joinType: JoinType, filter: Expression)`
* `case class JoinKey(leftKeys: Seq[Expression], rightKeys: Seq[Expression])`
* `trait CompactBufferBuilder extends java.io.Serializable `
* `class IteratorBufferBuilder extends CompactBufferBuilder `
* `class HashedBufferBuilder(relation: HashedRelation) extends CompactBufferBuilder `
* `class CorrelatedBufferBuilder(key: Projection, relation: HashedRelation)`
* `class ConstantBufferBuilder(row: Row) extends CompactBufferBuilder `
* `trait MultiwayJoin `
* ` class MultiBuild extends HashSet[Int] with BuildSide `
* This patch does not change any dependencies.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3862] [SQL] [WIP] MultiWayBroadcastJoin...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5326#issuecomment-88771528
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29591/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3862] [SQL] [WIP] MultiWayBroadcastJoin...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5326#issuecomment-89213689
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29650/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3862] [SQL] [WIP] MultiWayBroadcastJoin...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5326#issuecomment-88784043
[Test build #29595 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29595/consoleFull) for PR 5326 at commit [`3954ba4`](https://github.com/apache/spark/commit/3954ba4d312cffe6e71830a7d974c00f4e2b6b6a).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3862] [SQL] [WIP] MultiWayBroadcastJoin...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5326#issuecomment-89183925
[Test build #29650 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29650/consoleFull) for PR 5326 at commit [`e62be3b`](https://github.com/apache/spark/commit/e62be3bb17361be01e3a238c74bc86fa4bb3dae3).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3862] [SQL] [WIP] MultiWayBroadcastJoin...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5326#issuecomment-88817260
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29596/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3862] [SQL] [WIP] MultiWayBroadcastJoin...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5326#issuecomment-88812169
[Test build #29595 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29595/consoleFull) for PR 5326 at commit [`3954ba4`](https://github.com/apache/spark/commit/3954ba4d312cffe6e71830a7d974c00f4e2b6b6a).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `case class DimensionJoin(`
* `case class JoinFilter(joinType: JoinType, filter: Expression)`
* `case class JoinKey(leftKeys: Seq[Expression], rightKeys: Seq[Expression])`
* `trait CompactBufferBuilder extends java.io.Serializable `
* `class IteratorBufferBuilder extends CompactBufferBuilder `
* `class HashedBufferBuilder(relation: HashedRelation) extends CompactBufferBuilder `
* `class CorrelatedBufferBuilder(key: Projection, relation: HashedRelation)`
* `class ConstantBufferBuilder(row: Row) extends CompactBufferBuilder `
* `trait MultiwayJoin `
* ` class MultiBuild extends HashSet[Int] with BuildSide `
* This patch does not change any dependencies.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3862] [SQL] [WIP] MultiWayBroadcastJoin...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5326#issuecomment-88762001
[Test build #29591 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29591/consoleFull) for PR 5326 at commit [`b4cbabd`](https://github.com/apache/spark/commit/b4cbabdb541192ea0e8864627ea8d3b25523e5b3).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3862] [SQL] [WIP] MultiWayBroadcastJoin...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5326#issuecomment-88984495
[Test build #29613 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29613/consoleFull) for PR 5326 at commit [`e60b7a1`](https://github.com/apache/spark/commit/e60b7a19c1787df69e7856877c523d8438c48e01).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `case class DimensionJoin(`
* `case class JoinFilter(joinType: JoinType, filter: Expression)`
* `case class JoinKey(leftKeys: Seq[Expression], rightKeys: Seq[Expression])`
* `trait CompactBufferBuilder extends java.io.Serializable `
* `class IteratorBufferBuilder extends CompactBufferBuilder `
* `class HashedBufferBuilder(relation: HashedRelation) extends CompactBufferBuilder `
* `class CorrelatedBufferBuilder(key: Projection, relation: HashedRelation)`
* `class ConstantBufferBuilder(row: Row) extends CompactBufferBuilder `
* `trait MultiwayJoin `
* ` class MultiBuild extends HashSet[Int] with BuildSide `
* This patch does not change any dependencies.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3862] [SQL] [WIP] MultiWayBroadcastJoin...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5326#issuecomment-88984515
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29613/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3862] [SQL] [WIP] MultiWayBroadcastJoin...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5326#issuecomment-88785248
[Test build #29596 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29596/consoleFull) for PR 5326 at commit [`987bbc3`](https://github.com/apache/spark/commit/987bbc3941528707e59be8aea0dcb568f9c7fd55).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3862] [SQL] [WIP] MultiWayBroadcastJoin...
Posted by chenghao-intel <gi...@git.apache.org>.
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/5326#issuecomment-91948213
Closing it for now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org