You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Boris Shkolnik (JIRA)" <ji...@apache.org> on 2008/11/21 23:01:45 UTC
[jira] Created: (HADOOP-4708) Add support for dfsadmin commands for
test TestCLI unit test
Add support for dfsadmin commands for test TestCLI unit test
------------------------------------------------------------
Key: HADOOP-4708
URL: https://issues.apache.org/jira/browse/HADOOP-4708
Project: Hadoop Core
Issue Type: New Feature
Components: test
Reporter: Boris Shkolnik
Curretly TestCLI assumes dfs command when describing tests in testConf.xml
we need to add ability to run dfsadmin commands too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4708) Add support for dfsadmin commands for
test TestCLI unit test
Posted by "Boris Shkolnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Boris Shkolnik updated HADOOP-4708:
-----------------------------------
Fix Version/s: 0.20.0
Status: Patch Available (was: Open)
> Add support for dfsadmin commands for test TestCLI unit test
> ------------------------------------------------------------
>
> Key: HADOOP-4708
> URL: https://issues.apache.org/jira/browse/HADOOP-4708
> Project: Hadoop Core
> Issue Type: New Feature
> Components: test
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Fix For: 0.20.0
>
> Attachments: HADOOP-4708.patch
>
>
> Curretly TestCLI assumes dfs command when describing tests in testConf.xml
> we need to add ability to run dfsadmin commands too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4708) Add support for dfsadmin commands for
test TestCLI unit test
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-4708:
----------------------------------
Status: Open (was: Patch Available)
> Add support for dfsadmin commands for test TestCLI unit test
> ------------------------------------------------------------
>
> Key: HADOOP-4708
> URL: https://issues.apache.org/jira/browse/HADOOP-4708
> Project: Hadoop Core
> Issue Type: New Feature
> Components: test
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Fix For: 0.20.0
>
> Attachments: HADOOP-4708.patch
>
>
> Curretly TestCLI assumes dfs command when describing tests in testConf.xml
> we need to add ability to run dfsadmin commands too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4708) Add support for dfsadmin commands
for test TestCLI unit test
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12655277#action_12655277 ]
Hudson commented on HADOOP-4708:
--------------------------------
Integrated in Hadoop-trunk #684 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/684/])
. Add binaries missed in the initial checkin for Chukwa. Contributed by Eric Yang.
> Add support for dfsadmin commands for test TestCLI unit test
> ------------------------------------------------------------
>
> Key: HADOOP-4708
> URL: https://issues.apache.org/jira/browse/HADOOP-4708
> Project: Hadoop Core
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.20.0
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Fix For: 0.20.0
>
> Attachments: HADOOP-4708.patch, HADOOP-4708-1.patch
>
>
> Curretly TestCLI assumes dfs command when describing tests in testConf.xml
> we need to add ability to run dfsadmin commands too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4708) Add support for dfsadmin commands for
test TestCLI unit test
Posted by "Boris Shkolnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Boris Shkolnik updated HADOOP-4708:
-----------------------------------
Attachment: HADOOP-4708.patch
patch
> Add support for dfsadmin commands for test TestCLI unit test
> ------------------------------------------------------------
>
> Key: HADOOP-4708
> URL: https://issues.apache.org/jira/browse/HADOOP-4708
> Project: Hadoop Core
> Issue Type: New Feature
> Components: test
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Attachments: HADOOP-4708.patch
>
>
> Curretly TestCLI assumes dfs command when describing tests in testConf.xml
> we need to add ability to run dfsadmin commands too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4708) Add support for dfsadmin commands
for test TestCLI unit test
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12651172#action_12651172 ]
Hadoop QA commented on HADOOP-4708:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12394680/+HADOOP-4708.patch
against trunk revision 720930.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 9 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3655/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3655/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3655/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3655/console
This message is automatically generated.
> Add support for dfsadmin commands for test TestCLI unit test
> ------------------------------------------------------------
>
> Key: HADOOP-4708
> URL: https://issues.apache.org/jira/browse/HADOOP-4708
> Project: Hadoop Core
> Issue Type: New Feature
> Components: test
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Fix For: 0.20.0
>
> Attachments: HADOOP-4708.patch
>
>
> Curretly TestCLI assumes dfs command when describing tests in testConf.xml
> we need to add ability to run dfsadmin commands too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4708) Add support for dfsadmin commands for
test TestCLI unit test
Posted by "Boris Shkolnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Boris Shkolnik updated HADOOP-4708:
-----------------------------------
Attachment: HADOOP-4708-1.patch
> Add support for dfsadmin commands for test TestCLI unit test
> ------------------------------------------------------------
>
> Key: HADOOP-4708
> URL: https://issues.apache.org/jira/browse/HADOOP-4708
> Project: Hadoop Core
> Issue Type: New Feature
> Components: test
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Fix For: 0.20.0
>
> Attachments: HADOOP-4708.patch, HADOOP-4708-1.patch
>
>
> Curretly TestCLI assumes dfs command when describing tests in testConf.xml
> we need to add ability to run dfsadmin commands too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4708) Add support for dfsadmin commands for
test TestCLI unit test
Posted by "Boris Shkolnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Boris Shkolnik updated HADOOP-4708:
-----------------------------------
Status: Patch Available (was: Open)
recommended fixes to the patch:
1. moving logic of selecting correct function for a type of command to CommandExecutor (I think it makes sense to do it now, cause it is more clean)
2. making get methods final
3. removing unnecessary formating and casting.
4. changed to switch from if-else with a default throw.
I left getCmd and not toString() - it makes more sense.
> Add support for dfsadmin commands for test TestCLI unit test
> ------------------------------------------------------------
>
> Key: HADOOP-4708
> URL: https://issues.apache.org/jira/browse/HADOOP-4708
> Project: Hadoop Core
> Issue Type: New Feature
> Components: test
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Fix For: 0.20.0
>
> Attachments: HADOOP-4708.patch, HADOOP-4708-1.patch
>
>
> Curretly TestCLI assumes dfs command when describing tests in testConf.xml
> we need to add ability to run dfsadmin commands too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4708) Add support for dfsadmin commands for
test TestCLI unit test
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-4708:
----------------------------------
Issue Type: Improvement (was: New Feature)
Hadoop Flags: [Reviewed]
> Add support for dfsadmin commands for test TestCLI unit test
> ------------------------------------------------------------
>
> Key: HADOOP-4708
> URL: https://issues.apache.org/jira/browse/HADOOP-4708
> Project: Hadoop Core
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.20.0
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Fix For: 0.20.0
>
> Attachments: HADOOP-4708.patch, HADOOP-4708-1.patch
>
>
> Curretly TestCLI assumes dfs command when describing tests in testConf.xml
> we need to add ability to run dfsadmin commands too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4708) Add support for dfsadmin commands for
test TestCLI unit test
Posted by "Boris Shkolnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Boris Shkolnik updated HADOOP-4708:
-----------------------------------
Attachment: (was: HADOOP-4708-1.patch)
> Add support for dfsadmin commands for test TestCLI unit test
> ------------------------------------------------------------
>
> Key: HADOOP-4708
> URL: https://issues.apache.org/jira/browse/HADOOP-4708
> Project: Hadoop Core
> Issue Type: New Feature
> Components: test
> Affects Versions: 0.20.0
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Fix For: 0.20.0
>
> Attachments: HADOOP-4708.patch
>
>
> Curretly TestCLI assumes dfs command when describing tests in testConf.xml
> we need to add ability to run dfsadmin commands too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4708) Add support for dfsadmin commands for
test TestCLI unit test
Posted by "Boris Shkolnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Boris Shkolnik updated HADOOP-4708:
-----------------------------------
Attachment: (was: HADOOP-4708-1.patch)
> Add support for dfsadmin commands for test TestCLI unit test
> ------------------------------------------------------------
>
> Key: HADOOP-4708
> URL: https://issues.apache.org/jira/browse/HADOOP-4708
> Project: Hadoop Core
> Issue Type: New Feature
> Components: test
> Affects Versions: 0.20.0
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Fix For: 0.20.0
>
> Attachments: HADOOP-4708.patch
>
>
> Curretly TestCLI assumes dfs command when describing tests in testConf.xml
> we need to add ability to run dfsadmin commands too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4708) Add support for dfsadmin commands for
test TestCLI unit test
Posted by "Boris Shkolnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Boris Shkolnik updated HADOOP-4708:
-----------------------------------
Attachment: HADOOP-4708-1.patch
> Add support for dfsadmin commands for test TestCLI unit test
> ------------------------------------------------------------
>
> Key: HADOOP-4708
> URL: https://issues.apache.org/jira/browse/HADOOP-4708
> Project: Hadoop Core
> Issue Type: New Feature
> Components: test
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Fix For: 0.20.0
>
> Attachments: HADOOP-4708-1.patch, HADOOP-4708.patch
>
>
> Curretly TestCLI assumes dfs command when describing tests in testConf.xml
> we need to add ability to run dfsadmin commands too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4708) Add support for dfsadmin commands
for test TestCLI unit test
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12652801#action_12652801 ]
Hudson commented on HADOOP-4708:
--------------------------------
Integrated in Hadoop-trunk #677 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/677/])
. Add support for dfsadmin commands in TestCLI. Contributed by Boris Shkolnik.
> Add support for dfsadmin commands for test TestCLI unit test
> ------------------------------------------------------------
>
> Key: HADOOP-4708
> URL: https://issues.apache.org/jira/browse/HADOOP-4708
> Project: Hadoop Core
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.20.0
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Fix For: 0.20.0
>
> Attachments: HADOOP-4708.patch, HADOOP-4708-1.patch
>
>
> Curretly TestCLI assumes dfs command when describing tests in testConf.xml
> we need to add ability to run dfsadmin commands too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4708) Add support for dfsadmin commands
for test TestCLI unit test
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12651159#action_12651159 ]
Chris Douglas commented on HADOOP-4708:
---------------------------------------
It would be nice if more of the CommandExecutor logic were part of the enumerated type, but it's not necessary for this patch.
* For enums:
{noformat}
+ if(cmd.getType()==CommandType.ADMIN) {
+ CommandExecutor.executeDFSAdminCommand(cmd.getCmd(), namenode);
+ } else {
+ CommandExecutor.executeFSCommand(cmd.getCmd(), namenode);
+ }
{noformat}
This should probably be a switch stmt.
* This change is unnecessary:
{noformat}
@@ -107,8 +109,7 @@
conf = new Configuration();
cluster = new MiniDFSCluster(conf, 1, true, null);
namenode = conf.get("fs.default.name", "file:///");
- clitestDataDir = new File(TEST_CACHE_DATA_DIR).
- toURI().toString().replace(' ', '+');
+ clitestDataDir = new File(TEST_CACHE_DATA_DIR).toURI().toString().replace(' ', '+');
username = System.getProperty("user.name");
{noformat}
* TestCmd.type and TestCmd.cmd can be final
* Why getCmd instead of just toString()?
* The cast to String is (still) unnecessary:
{noformat}
- expandCommand((String) testCommands.get(j)) + "]");
+ expandCommand((String) testCommands.get(j).getCmd()) + "]");
{noformat}
> Add support for dfsadmin commands for test TestCLI unit test
> ------------------------------------------------------------
>
> Key: HADOOP-4708
> URL: https://issues.apache.org/jira/browse/HADOOP-4708
> Project: Hadoop Core
> Issue Type: New Feature
> Components: test
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Fix For: 0.20.0
>
> Attachments: HADOOP-4708.patch
>
>
> Curretly TestCLI assumes dfs command when describing tests in testConf.xml
> we need to add ability to run dfsadmin commands too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4708) Add support for dfsadmin commands for
test TestCLI unit test
Posted by "Boris Shkolnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Boris Shkolnik updated HADOOP-4708:
-----------------------------------
Status: Patch Available (was: Open)
> Add support for dfsadmin commands for test TestCLI unit test
> ------------------------------------------------------------
>
> Key: HADOOP-4708
> URL: https://issues.apache.org/jira/browse/HADOOP-4708
> Project: Hadoop Core
> Issue Type: New Feature
> Components: test
> Affects Versions: 0.20.0
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Fix For: 0.20.0
>
> Attachments: HADOOP-4708.patch, HADOOP-4708-1.patch
>
>
> Curretly TestCLI assumes dfs command when describing tests in testConf.xml
> we need to add ability to run dfsadmin commands too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4708) Add support for dfsadmin commands for
test TestCLI unit test
Posted by "Boris Shkolnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Boris Shkolnik updated HADOOP-4708:
-----------------------------------
Attachment: HADOOP-4708-1.patch
> Add support for dfsadmin commands for test TestCLI unit test
> ------------------------------------------------------------
>
> Key: HADOOP-4708
> URL: https://issues.apache.org/jira/browse/HADOOP-4708
> Project: Hadoop Core
> Issue Type: New Feature
> Components: test
> Affects Versions: 0.20.0
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Fix For: 0.20.0
>
> Attachments: HADOOP-4708.patch, HADOOP-4708-1.patch
>
>
> Curretly TestCLI assumes dfs command when describing tests in testConf.xml
> we need to add ability to run dfsadmin commands too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4708) Add support for dfsadmin commands for
test TestCLI unit test
Posted by "Boris Shkolnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Boris Shkolnik updated HADOOP-4708:
-----------------------------------
Attachment: (was: HADOOP-4708-1.patch)
> Add support for dfsadmin commands for test TestCLI unit test
> ------------------------------------------------------------
>
> Key: HADOOP-4708
> URL: https://issues.apache.org/jira/browse/HADOOP-4708
> Project: Hadoop Core
> Issue Type: New Feature
> Components: test
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Fix For: 0.20.0
>
> Attachments: HADOOP-4708.patch
>
>
> Curretly TestCLI assumes dfs command when describing tests in testConf.xml
> we need to add ability to run dfsadmin commands too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4708) Add support for dfsadmin commands for
test TestCLI unit test
Posted by "Boris Shkolnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Boris Shkolnik updated HADOOP-4708:
-----------------------------------
Status: Open (was: Patch Available)
> Add support for dfsadmin commands for test TestCLI unit test
> ------------------------------------------------------------
>
> Key: HADOOP-4708
> URL: https://issues.apache.org/jira/browse/HADOOP-4708
> Project: Hadoop Core
> Issue Type: New Feature
> Components: test
> Affects Versions: 0.20.0
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Fix For: 0.20.0
>
> Attachments: HADOOP-4708.patch
>
>
> Curretly TestCLI assumes dfs command when describing tests in testConf.xml
> we need to add ability to run dfsadmin commands too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4708) Add support for dfsadmin commands for
test TestCLI unit test
Posted by "Boris Shkolnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Boris Shkolnik updated HADOOP-4708:
-----------------------------------
Status: Patch Available (was: Open)
> Add support for dfsadmin commands for test TestCLI unit test
> ------------------------------------------------------------
>
> Key: HADOOP-4708
> URL: https://issues.apache.org/jira/browse/HADOOP-4708
> Project: Hadoop Core
> Issue Type: New Feature
> Components: test
> Affects Versions: 0.20.0
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Fix For: 0.20.0
>
> Attachments: HADOOP-4708.patch, HADOOP-4708-1.patch
>
>
> Curretly TestCLI assumes dfs command when describing tests in testConf.xml
> we need to add ability to run dfsadmin commands too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HADOOP-4708) Add support for dfsadmin commands
for test TestCLI unit test
Posted by "Boris Shkolnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Boris Shkolnik reassigned HADOOP-4708:
--------------------------------------
Assignee: Boris Shkolnik
> Add support for dfsadmin commands for test TestCLI unit test
> ------------------------------------------------------------
>
> Key: HADOOP-4708
> URL: https://issues.apache.org/jira/browse/HADOOP-4708
> Project: Hadoop Core
> Issue Type: New Feature
> Components: test
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
>
> Curretly TestCLI assumes dfs command when describing tests in testConf.xml
> we need to add ability to run dfsadmin commands too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4708) Add support for dfsadmin commands for
test TestCLI unit test
Posted by "Boris Shkolnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Boris Shkolnik updated HADOOP-4708:
-----------------------------------
Attachment: HADOOP-4708-1.patch
> Add support for dfsadmin commands for test TestCLI unit test
> ------------------------------------------------------------
>
> Key: HADOOP-4708
> URL: https://issues.apache.org/jira/browse/HADOOP-4708
> Project: Hadoop Core
> Issue Type: New Feature
> Components: test
> Affects Versions: 0.20.0
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Fix For: 0.20.0
>
> Attachments: HADOOP-4708.patch, HADOOP-4708-1.patch
>
>
> Curretly TestCLI assumes dfs command when describing tests in testConf.xml
> we need to add ability to run dfsadmin commands too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4708) Add support for dfsadmin commands
for test TestCLI unit test
Posted by "Boris Shkolnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12649833#action_12649833 ]
Boris Shkolnik commented on HADOOP-4708:
----------------------------------------
I suggest we add <admin-command> to testConf.xml to describe a dfsadmin command to be run by the framework.
implementation wise we should change a command from being a String to be a class that knows what type of command it is and use DFSShell for dfsadmin commands.
> Add support for dfsadmin commands for test TestCLI unit test
> ------------------------------------------------------------
>
> Key: HADOOP-4708
> URL: https://issues.apache.org/jira/browse/HADOOP-4708
> Project: Hadoop Core
> Issue Type: New Feature
> Components: test
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
>
> Curretly TestCLI assumes dfs command when describing tests in testConf.xml
> we need to add ability to run dfsadmin commands too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4708) Add support for dfsadmin commands for
test TestCLI unit test
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-4708:
----------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
+1
I just committed this. Thanks, Boris
> Add support for dfsadmin commands for test TestCLI unit test
> ------------------------------------------------------------
>
> Key: HADOOP-4708
> URL: https://issues.apache.org/jira/browse/HADOOP-4708
> Project: Hadoop Core
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.20.0
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Fix For: 0.20.0
>
> Attachments: HADOOP-4708.patch, HADOOP-4708-1.patch
>
>
> Curretly TestCLI assumes dfs command when describing tests in testConf.xml
> we need to add ability to run dfsadmin commands too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4708) Add support for dfsadmin commands for
test TestCLI unit test
Posted by "Boris Shkolnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Boris Shkolnik updated HADOOP-4708:
-----------------------------------
Affects Version/s: 0.20.0
Status: Open (was: Patch Available)
> Add support for dfsadmin commands for test TestCLI unit test
> ------------------------------------------------------------
>
> Key: HADOOP-4708
> URL: https://issues.apache.org/jira/browse/HADOOP-4708
> Project: Hadoop Core
> Issue Type: New Feature
> Components: test
> Affects Versions: 0.20.0
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Fix For: 0.20.0
>
> Attachments: HADOOP-4708.patch
>
>
> Curretly TestCLI assumes dfs command when describing tests in testConf.xml
> we need to add ability to run dfsadmin commands too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.