[jira] Commented: (SYNAPSE-572) XSLT Mediator possibility of creating multiple Templates by mutiple threads

["Ruwan Linton (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SYNAPSE-572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12746417#action_12746417 ] 

Ruwan Linton commented on SYNAPSE-572:
--------------------------------------

I don't agree, to me the first occurrence should be part of the function out put of reCreateTemplate, also this name is ambiguous the name of the method depicts that it recreates the template, but it is not, it is just a conditional check.

One more thing is that according to the flow if we are to keep the above two cases as two separate cases we should be having the second case first.

Just a few comments but this patch is very useful. I will apply the patch with the above specified changes, please have a look and verify the functionality. 

> XSLT Mediator possibility of creating multiple Templates by mutiple threads
> ---------------------------------------------------------------------------
>
>                 Key: SYNAPSE-572
>                 URL: https://issues.apache.org/jira/browse/SYNAPSE-572
>             Project: Synapse
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Supun Kamburugamuva
>            Assignee: Ruwan Linton
>         Attachments: synapse-572.patch
>
>
> With the current code multiple threads can create the XSLT template after seeing that the cache has expired. Also we are always doing a synchronization for creating the template which can be costly. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org