You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/10/09 16:51:19 UTC
[GitHub] [cloudstack-kubernetes-provider] davidjumani opened a new pull request #22: Update libraries
davidjumani opened a new pull request #22:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/22
Fixes https://github.com/apache/cloudstack-kubernetes-provider/issues/20
Updated the Kubernetes framework to v1.18 since 1.19 introduces `cloudprovider.Interface.InstancesV2` which is experimental and could change in v1.20
https://github.com/kubernetes/cloud-provider/blob/release-1.19/cloud.go#L56
Added `get_kubernetes_dep.sh` to fetch and tweak the kubernetes framework since simply updating it causes issues :
https://github.com/kubernetes/client-go/issues/741
https://github.com/kubernetes/kubernetes/issues/79384#issuecomment-505725449
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] davidjumani commented on pull request #22: Update kubernetes libraries
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #22:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/22#issuecomment-719425005
@rhtyd Could you merge this? Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] onitake edited a comment on pull request #22: Update kubernetes libraries
Posted by GitBox <gi...@apache.org>.
onitake edited a comment on pull request #22:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/22#issuecomment-718068080
Sorry @davidjumani , this got lost under other stuff.
The framework update script looks very useful indeed!
It was a lot of hassle to manually update the commti hashes in the past.
This looks good to me, go for it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] davidjumani commented on pull request #22: Update kubernetes libraries
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #22:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/22#issuecomment-714905054
@onitake Could you review the changes ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] onitake commented on pull request #22: Update kubernetes libraries
Posted by GitBox <gi...@apache.org>.
onitake commented on pull request #22:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/22#issuecomment-718068080
Sorry @davidjumani , this got lost under other stuff.
The framework update script looks very useful indeed!
It was a lot of hassle to manually update the commti hashes in the past.
Aside from that, this looks good to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] davidjumani commented on pull request #22: Update kubernetes libraries
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #22:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/22#issuecomment-710111511
Tests pass. Good to go @onitake
```
go test -v ./...
=== RUN TestReadConfig
--- PASS: TestReadConfig (0.00s)
=== RUN TestNewCSCloud
cloudstack_test.go:89: No config found in environment
--- SKIP: TestNewCSCloud (0.00s)
=== RUN TestLoadBalancer
cloudstack_test.go:101: No config found in environment
--- SKIP: TestLoadBalancer (0.00s)
PASS
ok github.com/apache/cloudstack-kubernetes-provider (cached)
? github.com/apache/cloudstack-kubernetes-provider/cmd/cloudstack-ccm [no test files]
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] rhtyd merged pull request #22: Update kubernetes libraries
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #22:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/22
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org