You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildstream.apache.org by GitBox <gi...@apache.org> on 2022/12/04 05:19:54 UTC

[GitHub] [buildstream] gtristan opened a new issue, #1796: The `mypy` checks in CI are now failing

gtristan opened a new issue, #1796:
URL: https://github.com/apache/buildstream/issues/1796

   The `mypy` checks in CI fail with the following:
   
   ```
   mypy run-test: commands[0] | mypy
   src/buildstream/utils.py:47: error: Library stubs not installed for "google.protobuf" (or incompatible with Python 3.10)
   src/buildstream/storage/_casbaseddirectory.py:26: error: Library stubs not installed for "google.protobuf" (or incompatible with Python 3.10)
   src/buildstream/storage/_casbaseddirectory.py:26: note: Hint: "python3 -m pip install types-protobuf"
   src/buildstream/storage/_casbaseddirectory.py:26: note: (or run "mypy --install-types" to install all missing stub packages)
   src/buildstream/storage/_casbaseddirectory.py:26: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
   Found 2 errors in 2 files (checked 186 source files)
   ERROR: InvocationError for command /home/testuser/buildstream/.tox/mypy/bin/mypy (exited with code 1)
   ```
   They pass perfectly fine with python3.9, but for some reason we are running them with python 3.10 which perhaps is not yet mature enough.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] The `mypy` checks in CI are now failing [buildstream]

Posted by "abderrahim (via GitHub)" <gi...@apache.org>.
abderrahim closed issue #1796: The `mypy` checks in CI are now failing
URL: https://github.com/apache/buildstream/issues/1796


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [buildstream] cs-shadow commented on issue #1796: The `mypy` checks in CI are now failing

Posted by "cs-shadow (via GitHub)" <gi...@apache.org>.
cs-shadow commented on issue #1796:
URL: https://github.com/apache/buildstream/issues/1796#issuecomment-1540682468

   @gtristan is this issue still relevant?
   
   I can see that this pipeline from a couple months back is passing mypy checks - https://github.com/apache/buildstream/actions/runs/4499768440/jobs/8204842204?pr=1834


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] The `mypy` checks in CI are now failing [buildstream]

Posted by "abderrahim (via GitHub)" <gi...@apache.org>.
abderrahim commented on issue #1796:
URL: https://github.com/apache/buildstream/issues/1796#issuecomment-2002039202

   This started failing again recently (the test is now running on python 3.11). I fixed it by pinning the version of types-protobuf and friends https://github.com/apache/buildstream/pull/1900.
   
   Closing this as it should hopefully not happen again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org