[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #493: [WIP]Ftr : Add eureka service discovery

[GitBox <gi...@apache.org>]

AlexStocks commented on a change in pull request #493:
URL: https://github.com/apache/dubbo-go/pull/493#discussion_r419056659



##########
File path: registry/eureka/service_discovery.go
##########
@@ -97,36 +97,64 @@ func (e *eurekaServiceDiscovery) GetDefaultPageSize() int {
 }
 
 func (e *eurekaServiceDiscovery) GetServices() *gxset.HashSet {
-	e.eurekaConnection.SelectServiceURL()
-	services := e.eurekaConnection.ServiceUrls
 	res := gxset.NewSet()
-	for _, e := range services {
-		res.Add(e)
+	apps, err := e.eurekaConnection.GetApps()
+	if err != nil {
+		logger.Errorf("GetServices getApps fail error: %s", err)

Review comment:
       pls use %+v instead of %s for error to handle nil error or self-defined error.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org