[jira] Assigned: (WICKET-1207) AjaxEditableChoiceLabel should not be MultiLineLabel (wrapped in p)

["Johan Compagner (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/WICKET-1207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Johan Compagner reassigned WICKET-1207:
---------------------------------------

    Assignee: Eelco Hillenius

I guess its by design that its a multiline label because choices can be multi selected?
What i do find strange is th difference between the other 2 AjaxEditableXXX components for example this check:

protected void onComponentTagBody(MarkupStream markupStream, ComponentTag openTag)
			{
				Object modelObject = getModelObject();
				if (modelObject == null || "".equals(modelObject))
				{
					replaceComponentTagBody(markupStream, openTag, defaultNullLabel());
				}
				else
				{
					super.onComponentTagBody(markupStream, openTag);
				}
			}
eelco can have a quick look

> AjaxEditableChoiceLabel should not be MultiLineLabel (wrapped in p)
> -------------------------------------------------------------------
>
>                 Key: WICKET-1207
>                 URL: https://issues.apache.org/jira/browse/WICKET-1207
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket-extensions
>    Affects Versions: 1.3.0-rc1
>            Reporter: Anders Janmyr
>            Assignee: Eelco Hillenius
>            Priority: Trivial
>
> When an AjaxEditableChoiceLabel is rendered it is rendered as a MultiLineLabel.
> This adds an unnecessary paragraph around.
> A fix is simple:  Replace MultiLineLabel with Label in the newLabel method.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.