You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by GitBox <gi...@apache.org> on 2022/09/08 18:24:22 UTC
[GitHub] [spark-website] abubakrsiddq opened a new pull request, #412: correct typo in rdd-programming-guide
abubakrsiddq opened a new pull request, #412:
URL: https://github.com/apache/spark-website/pull/412
Fraction was repeated twice in guide corrected it
<!-- *Make sure that you generate site HTML with `bundle exec jekyll build`, and include the changes to the HTML in your pull request. See README.md for more information.* -->
Also corrected in spark docs in this PR https://github.com/apache/spark/pull/37839
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org
[GitHub] [spark-website] srowen commented on a diff in pull request #412: correct typo in rdd-programming-guide
Posted by GitBox <gi...@apache.org>.
srowen commented on code in PR #412:
URL: https://github.com/apache/spark-website/pull/412#discussion_r966303620
##########
site/docs/2.2.0/rdd-programming-guide.html:
##########
@@ -1088,7 +1088,7 @@ <h3 id="transformations">Transformations</h3>
</tr>
<tr>
<td> <b>sample</b>(<i>withReplacement</i>, <i>fraction</i>, <i>seed</i>) </td>
- <td> Sample a fraction <i>fraction</i> of the data, with or without replacement, using a given random number generator seed. </td>
+ <td> Sample a <i>fraction</i> of the data, with or without replacement, using a given random number generator seed. </td>
Review Comment:
Yes you would update that .md file, but I do not think this is a typo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org
[GitHub] [spark-website] abubakrsiddq commented on a diff in pull request #412: correct typo in rdd-programming-guide
Posted by GitBox <gi...@apache.org>.
abubakrsiddq commented on code in PR #412:
URL: https://github.com/apache/spark-website/pull/412#discussion_r966318932
##########
site/docs/2.2.0/rdd-programming-guide.html:
##########
@@ -1088,7 +1088,7 @@ <h3 id="transformations">Transformations</h3>
</tr>
<tr>
<td> <b>sample</b>(<i>withReplacement</i>, <i>fraction</i>, <i>seed</i>) </td>
- <td> Sample a fraction <i>fraction</i> of the data, with or without replacement, using a given random number generator seed. </td>
+ <td> Sample a <i>fraction</i> of the data, with or without replacement, using a given random number generator seed. </td>
Review Comment:
I felt that the italics was enough for giving away its an arg, repetition would not be right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org
[GitHub] [spark-website] srowen commented on pull request #412: correct typo in rdd-programming-guide
Posted by GitBox <gi...@apache.org>.
srowen commented on PR #412:
URL: https://github.com/apache/spark-website/pull/412#issuecomment-1241077101
You're right, but, that's a copy of the documentation from a very old version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org
[GitHub] [spark-website] abubakrsiddq commented on a diff in pull request #412: correct typo in rdd-programming-guide
Posted by GitBox <gi...@apache.org>.
abubakrsiddq commented on code in PR #412:
URL: https://github.com/apache/spark-website/pull/412#discussion_r966294077
##########
site/docs/2.2.0/rdd-programming-guide.html:
##########
@@ -1088,7 +1088,7 @@ <h3 id="transformations">Transformations</h3>
</tr>
<tr>
<td> <b>sample</b>(<i>withReplacement</i>, <i>fraction</i>, <i>seed</i>) </td>
- <td> Sample a fraction <i>fraction</i> of the data, with or without replacement, using a given random number generator seed. </td>
+ <td> Sample a <i>fraction</i> of the data, with or without replacement, using a given random number generator seed. </td>
Review Comment:
args are specified in the left field. looks to be a typo
Also do we just correct this file then https://github.com/apache/spark/blob/master/docs/rdd-programming-guide.md even for the site?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org
[GitHub] [spark-website] srowen commented on a diff in pull request #412: correct typo in rdd-programming-guide
Posted by GitBox <gi...@apache.org>.
srowen commented on code in PR #412:
URL: https://github.com/apache/spark-website/pull/412#discussion_r966289200
##########
site/docs/2.2.0/rdd-programming-guide.html:
##########
@@ -1088,7 +1088,7 @@ <h3 id="transformations">Transformations</h3>
</tr>
<tr>
<td> <b>sample</b>(<i>withReplacement</i>, <i>fraction</i>, <i>seed</i>) </td>
- <td> Sample a fraction <i>fraction</i> of the data, with or without replacement, using a given random number generator seed. </td>
+ <td> Sample a <i>fraction</i> of the data, with or without replacement, using a given random number generator seed. </td>
Review Comment:
This isn't a typo. It's saying that the fraction is given by the argument _fraction_.
Also, this is a PR against a copy of the docs generated for Spark 2.2.0. You would fix docs in the apache/spark source tree for the next release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org
[GitHub] [spark-website] abubakrsiddq commented on a diff in pull request #412: correct typo in rdd-programming-guide
Posted by GitBox <gi...@apache.org>.
abubakrsiddq commented on code in PR #412:
URL: https://github.com/apache/spark-website/pull/412#discussion_r966295937
##########
site/docs/2.2.0/rdd-programming-guide.html:
##########
@@ -1088,7 +1088,7 @@ <h3 id="transformations">Transformations</h3>
</tr>
<tr>
<td> <b>sample</b>(<i>withReplacement</i>, <i>fraction</i>, <i>seed</i>) </td>
- <td> Sample a fraction <i>fraction</i> of the data, with or without replacement, using a given random number generator seed. </td>
+ <td> Sample a <i>fraction</i> of the data, with or without replacement, using a given random number generator seed. </td>
Review Comment:
i was reading contribution gyuideline and it said to updatate here as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org
[GitHub] [spark-website] srowen closed pull request #412: correct typo in rdd-programming-guide
Posted by GitBox <gi...@apache.org>.
srowen closed pull request #412: correct typo in rdd-programming-guide
URL: https://github.com/apache/spark-website/pull/412
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org