You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/09/23 01:38:02 UTC
[GitHub] [apisix-ingress-controller] mangoGoForward opened a new pull request, #1051: feat: support sni based tls route
mangoGoForward opened a new pull request, #1051:
URL: https://github.com/apache/apisix-ingress-controller/pull/1051
Signed-off-by: mango <xu...@foxmail.com>
<!-- Please answer these questions before submitting a pull request -->
### Type of change:
<!-- Please delete options that are not relevant. -->
- [ ] Bugfix
- [x] New feature provided
- [ ] Improve performance
- [ ] Backport patches
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
Please see #547
### Pre-submission checklist:
<!--
Please follow the requirements:
1. Use Draft if the PR is not ready to be reviewed
2. Test is required for the feat/fix PR, unless you have a good reason
3. Doc is required for the feat PR
4. Use a new commit to resolve review instead of `push -f`
5. Use "request review" to notify the reviewer once you have resolved the review
-->
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [x] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix-ingress-controller#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a diff in pull request #1051: feat: support sni based tls route
Posted by GitBox <gi...@apache.org>.
tokers commented on code in PR #1051:
URL: https://github.com/apache/apisix-ingress-controller/pull/1051#discussion_r887418071
##########
samples/deploy/crd/v1/ApisixRoute.yaml:
##########
@@ -134,7 +134,7 @@ spec:
type: string
minLength: 1
required:
- - scope
+ - scope
Review Comment:
It looks like the style of YAML array is not consistent? I think we don't have to add two empty slices before the `-` symbol.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #1051: feat: support sni based tls route
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on PR #1051:
URL: https://github.com/apache/apisix-ingress-controller/pull/1051#issuecomment-1255764065
>
@mangoGoForward Thanks for your active contribution!
As I said, we can implement this feature into the v2 API version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] mangoGoForward commented on pull request #1051: feat: support sni based tls route
Posted by GitBox <gi...@apache.org>.
mangoGoForward commented on PR #1051:
URL: https://github.com/apache/apisix-ingress-controller/pull/1051#issuecomment-1140632756
Hi @tokers How can I generate a `crd`? The `Makefile` seems has no related command.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #1051: feat: support sni based tls route
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on PR #1051:
URL: https://github.com/apache/apisix-ingress-controller/pull/1051#issuecomment-1291626916
Now that we're in the v1.6 development cycle, do you have time to add e2e test cases to covet this one? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a diff in pull request #1051: feat: support sni based tls route
Posted by GitBox <gi...@apache.org>.
tokers commented on code in PR #1051:
URL: https://github.com/apache/apisix-ingress-controller/pull/1051#discussion_r887734044
##########
samples/deploy/crd/v1/ApisixRoute.yaml:
##########
@@ -134,7 +134,7 @@ spec:
type: string
minLength: 1
required:
- - scope
+ - scope
Review Comment:
OK, so just ignore my comment here. Let's resolve it in another PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #1051: feat: support sni based tls route
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on PR #1051:
URL: https://github.com/apache/apisix-ingress-controller/pull/1051#issuecomment-1143445653
Please merge master latest code, and resolve conflicts. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #1051: feat: support sni based tls route
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on PR #1051:
URL: https://github.com/apache/apisix-ingress-controller/pull/1051#issuecomment-1303184758
Don't worry, you can continue if you are interested. Otherwise see if others are interested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #1051: feat: support sni based tls route
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on PR #1051:
URL: https://github.com/apache/apisix-ingress-controller/pull/1051#issuecomment-1253101673
Hi, do you have time to pick up this one? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] mangoGoForward commented on pull request #1051: feat: support sni based tls route
Posted by GitBox <gi...@apache.org>.
mangoGoForward commented on PR #1051:
URL: https://github.com/apache/apisix-ingress-controller/pull/1051#issuecomment-1296474061
> Now that we're in the v1.6 development cycle, do you have time to add e2e test cases to covet this one? Thanks!
Sorry reply to late, will be completed this week
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] mangoGoForward commented on pull request #1051: feat: support sni based tls route
Posted by GitBox <gi...@apache.org>.
mangoGoForward commented on PR #1051:
URL: https://github.com/apache/apisix-ingress-controller/pull/1051#issuecomment-1140588280
> Please also add some e2e test cases to cover the SNI route feature.
Thanks, I will do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #1051: feat: support sni based tls route
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on PR #1051:
URL: https://github.com/apache/apisix-ingress-controller/pull/1051#issuecomment-1140714096
> n I generate a `crd`? Th
@mangoGoForward Unfortunately, current CRDs are manually maintained. We have https://github.com/apache/apisix-ingress-controller/issues/515 to track it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #1051: feat: support sni based tls route
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #1051:
URL: https://github.com/apache/apisix-ingress-controller/pull/1051#issuecomment-1139445296
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1051?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1051](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1051?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9c5ad20) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/92b89b37d2f63eab6f5c6deb6e3d2a5ccae975aa?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (92b89b3) will **decrease** coverage by `0.93%`.
> The diff coverage is `50.00%`.
```diff
@@ Coverage Diff @@
## master #1051 +/- ##
==========================================
- Coverage 31.91% 30.97% -0.94%
==========================================
Files 73 75 +2
Lines 7953 8794 +841
==========================================
+ Hits 2538 2724 +186
- Misses 5139 5776 +637
- Partials 276 294 +18
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1051?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/kube/translation/apisix\_route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1051/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3JvdXRlLmdv) | `20.57% <0.00%> (-0.86%)` | :arrow_down: |
| [pkg/apisix/stream\_route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1051/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9zdHJlYW1fcm91dGUuZ28=) | `36.84% <100.00%> (+0.41%)` | :arrow_up: |
| [pkg/kube/translation/global\_rule.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1051/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vZ2xvYmFsX3J1bGUuZ28=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [pkg/kube/translation/plugin.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1051/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vcGx1Z2luLmdv) | `57.54% <0.00%> (-42.46%)` | :arrow_down: |
| [pkg/kube/translation/apisix\_consumer.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1051/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X2NvbnN1bWVyLmdv) | `67.74% <0.00%> (-7.26%)` | :arrow_down: |
| [pkg/ingress/controller.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1051/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvY29udHJvbGxlci5nbw==) | `0.87% <0.00%> (-0.07%)` | :arrow_down: |
| [pkg/ingress/secret.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1051/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3Mvc2VjcmV0Lmdv) | `0.00% <0.00%> (ø)` | |
| [pkg/ingress/status.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1051/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3Mvc3RhdHVzLmdv) | `0.00% <0.00%> (ø)` | |
| [pkg/ingress/apisix\_tls.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1051/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvYXBpc2l4X3Rscy5nbw==) | `0.00% <0.00%> (ø)` | |
| ... and [10 more](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1051/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1051?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1051?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [795be22...9c5ad20](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1051?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] mangoGoForward commented on pull request #1051: feat: support sni based tls route
Posted by GitBox <gi...@apache.org>.
mangoGoForward commented on PR #1051:
URL: https://github.com/apache/apisix-ingress-controller/pull/1051#issuecomment-1144343163
> Please merge master latest code, and resolve conflicts. Thanks
OK. I will solve it later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 merged pull request #1051: feat: support sni based tls route
Posted by GitBox <gi...@apache.org>.
tao12345666333 merged PR #1051:
URL: https://github.com/apache/apisix-ingress-controller/pull/1051
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] mangoGoForward commented on pull request #1051: feat: support sni based tls route
Posted by GitBox <gi...@apache.org>.
mangoGoForward commented on PR #1051:
URL: https://github.com/apache/apisix-ingress-controller/pull/1051#issuecomment-1253291279
> Hi, do you have time to pick up this one? Thanks
Yes, the file conflicts solved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] mangoGoForward closed pull request #1051: feat: support sni based tls route
Posted by GitBox <gi...@apache.org>.
mangoGoForward closed pull request #1051: feat: support sni based tls route
URL: https://github.com/apache/apisix-ingress-controller/pull/1051
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] mangoGoForward commented on pull request #1051: feat: support sni based tls route
Posted by GitBox <gi...@apache.org>.
mangoGoForward commented on PR #1051:
URL: https://github.com/apache/apisix-ingress-controller/pull/1051#issuecomment-1144645897
> @mangoGoForward Please make the CI passed, it has some failures. Thanks!
OK, I haven't found the the target of this error, it may takes a while to resolve.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on a diff in pull request #1051: feat: support sni based tls route
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on code in PR #1051:
URL: https://github.com/apache/apisix-ingress-controller/pull/1051#discussion_r887441831
##########
samples/deploy/crd/v1/ApisixRoute.yaml:
##########
@@ -134,7 +134,7 @@ spec:
type: string
minLength: 1
required:
- - scope
+ - scope
Review Comment:
https://github.com/apache/apisix-ingress-controller/issues/1062
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on pull request #1051: feat: support sni based tls route
Posted by GitBox <gi...@apache.org>.
tokers commented on PR #1051:
URL: https://github.com/apache/apisix-ingress-controller/pull/1051#issuecomment-1140576415
@mangoGoForward Please make the CI pass, thanks! See https://github.com/apache/apisix-ingress-controller/runs/6623221714?check_suite_focus=true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #1051: feat: support sni based tls route
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on PR #1051:
URL: https://github.com/apache/apisix-ingress-controller/pull/1051#issuecomment-1196372945
@mangoGoForward hi, thanks for your contribution, we plan to enter v1.5 release window.
I have a few suggestions for this PR
* I would like to put this PR into v1.6
* Currently we have unified all resources to the v2 version of the API, I recommend implementing this feature only for the v2 version of ApisixRoute. Because when the v1.5 version is released, we will mark the v2beta3 version as deprecated. You can check #707 for more detail
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on pull request #1051: feat: support sni based tls route
Posted by GitBox <gi...@apache.org>.
tokers commented on PR #1051:
URL: https://github.com/apache/apisix-ingress-controller/pull/1051#issuecomment-1144625624
@mangoGoForward Please make the CI passed, it has some failures. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] mangoGoForward commented on a diff in pull request #1051: feat: support sni based tls route
Posted by GitBox <gi...@apache.org>.
mangoGoForward commented on code in PR #1051:
URL: https://github.com/apache/apisix-ingress-controller/pull/1051#discussion_r887438795
##########
samples/deploy/crd/v1/ApisixRoute.yaml:
##########
@@ -134,7 +134,7 @@ spec:
type: string
minLength: 1
required:
- - scope
+ - scope
Review Comment:
It modified by `yamllint`, I think two indentations is more readable. there are many yaml files which uses no indentation and two indentations both, I suggest to support `yamllint` to format those yaml files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] mangoGoForward closed pull request #1051: feat: support sni based tls route
Posted by GitBox <gi...@apache.org>.
mangoGoForward closed pull request #1051: feat: support sni based tls route
URL: https://github.com/apache/apisix-ingress-controller/pull/1051
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] mangoGoForward commented on a diff in pull request #1051: feat: support sni based tls route
Posted by GitBox <gi...@apache.org>.
mangoGoForward commented on code in PR #1051:
URL: https://github.com/apache/apisix-ingress-controller/pull/1051#discussion_r978267105
##########
samples/deploy/crd/v1/ApisixRoute.yaml:
##########
@@ -521,6 +521,8 @@ spec:
match:
type: object
properties:
+ host:
+ type: string
Review Comment:
Done
##########
pkg/kube/apisix/apis/config/v2beta3/types.go:
##########
@@ -217,7 +217,8 @@ type ApisixRouteStream struct {
type ApisixRouteStreamMatch struct {
// IngressPort represents the port listening on the Ingress proxy server.
// It should be pre-defined as APISIX doesn't support dynamic listening.
- IngressPort int32 `json:"ingressPort" yaml:"ingressPort"`
+ IngressPort int32 `json:"ingressPort" yaml:"ingressPort"`
+ Host string `json:"host,omitempty" yaml:"host,omitempty"`
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #1051: feat: support sni based tls route
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on PR #1051:
URL: https://github.com/apache/apisix-ingress-controller/pull/1051#issuecomment-1303139071
But we can do it in a follow-up PR #1438 @mangoGoForward
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] mangoGoForward commented on pull request #1051: feat: support sni based tls route
Posted by GitBox <gi...@apache.org>.
mangoGoForward commented on PR #1051:
URL: https://github.com/apache/apisix-ingress-controller/pull/1051#issuecomment-1140588076
> @mangoGoForward Please make the CI pass, thanks! See https://github.com/apache/apisix-ingress-controller/runs/6623221714?check_suite_focus=true.
I got some `connection refused` errors, this feature seems wouldn't effect the CI?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on a diff in pull request #1051: feat: support sni based tls route
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on code in PR #1051:
URL: https://github.com/apache/apisix-ingress-controller/pull/1051#discussion_r887441161
##########
samples/deploy/crd/v1/ApisixRoute.yaml:
##########
@@ -134,7 +134,7 @@ spec:
type: string
minLength: 1
required:
- - scope
+ - scope
Review Comment:
> I suggest to support yamllint to format those yaml files.
Good idea. I will create new issue for track it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] mangoGoForward commented on pull request #1051: feat: support sni based tls route
Posted by GitBox <gi...@apache.org>.
mangoGoForward commented on PR #1051:
URL: https://github.com/apache/apisix-ingress-controller/pull/1051#issuecomment-1303153164
> LGTM
>
> But I think a more complete case can be added in e2e. Create a certificate pair and use it for proxying.
Thanks, it absolutely need more test cases to cover it. I need to study how the TLS route with SNI works and how to test it, I am so poor about knowledge in this area.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #1051: feat: support sni based tls route
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on PR #1051:
URL: https://github.com/apache/apisix-ingress-controller/pull/1051#issuecomment-1298085256
Thanks! @mangoGoForward
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on a diff in pull request #1051: feat: support sni based tls route
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on code in PR #1051:
URL: https://github.com/apache/apisix-ingress-controller/pull/1051#discussion_r978240972
##########
samples/deploy/crd/v1/ApisixRoute.yaml:
##########
@@ -521,6 +521,8 @@ spec:
match:
type: object
properties:
+ host:
+ type: string
Review Comment:
please move this field to v2 api version section
##########
pkg/kube/apisix/apis/config/v2beta3/types.go:
##########
@@ -217,7 +217,8 @@ type ApisixRouteStream struct {
type ApisixRouteStreamMatch struct {
// IngressPort represents the port listening on the Ingress proxy server.
// It should be pre-defined as APISIX doesn't support dynamic listening.
- IngressPort int32 `json:"ingressPort" yaml:"ingressPort"`
+ IngressPort int32 `json:"ingressPort" yaml:"ingressPort"`
+ Host string `json:"host,omitempty" yaml:"host,omitempty"`
Review Comment:
move this to v2/types.go file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #1051: feat: support sni based tls route
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on PR #1051:
URL: https://github.com/apache/apisix-ingress-controller/pull/1051#issuecomment-1255947915
LGTM !
could you please add e2e test cases to covet this one? thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] mangoGoForward commented on pull request #1051: feat: support sni based tls route
Posted by GitBox <gi...@apache.org>.
mangoGoForward commented on PR #1051:
URL: https://github.com/apache/apisix-ingress-controller/pull/1051#issuecomment-1257412583
> LGTM !
>
> could you please add e2e test cases to covet this one? thanks!
Sure, but have no time to deal with it recently, I will improve it as soon as possible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org