You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/12/29 13:58:18 UTC

[GitHub] [arrow] edponce commented on a change in pull request #12036: ARROW-15194: [C++] ChunkedArray constructor is missing size and type validation

edponce commented on a change in pull request #12036:
URL: https://github.com/apache/arrow/pull/12036#discussion_r776339063



##########
File path: cpp/src/arrow/chunked_array_test.cc
##########
@@ -204,9 +210,9 @@ TEST_F(TestChunkedArray, Validate) {
   Construct();
   ASSERT_OK(one_->ValidateFull());
 
+  // Invalid if different chunk types
   arrays_one_.push_back(gen.String(50, 0, 10, 0.1));
-  Construct();
-  ASSERT_RAISES(Invalid, one_->ValidateFull());

Review comment:
       Yes, and it will pass, but this test is incorrect because it constructs a ChunkedArray with chunks of different types (Int32 and String).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org