[GitHub] [solr] magibney commented on a change in pull request #158: SOLR-15449: edismax sow and mm

[GitBox <gi...@apache.org>]

magibney commented on a change in pull request #158:
URL: https://github.com/apache/solr/pull/158#discussion_r644332142



##########
File path: solr/core/src/java/org/apache/solr/parser/SolrQueryParserBase.java
##########
@@ -1149,7 +1150,7 @@ protected Query getFieldQuery(String field, List<String> queryTerms, boolean raw
         return newFieldQuery
             (getAnalyzer(), field, queryText, false, fieldAutoGenPhraseQueries, fieldEnableGraphQueries, synonymQueryStyle);
       } else {
-        if (raw) {
+        if (raw) {// assumption: raw = false only when called from ExtendedDismaxQueryParser.getQuery()

Review comment:
       I wonder whether it makes more sense to leave this "assumption" comment where it was -- at the point that the exception is swallowed? No doubt the comment is _true_ either place, but placing the comment up here separates it from where action is taken _based_ on that assumption.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org