You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/10/26 19:29:35 UTC

[GitHub] [activemq-artemis] jbertram commented on pull request #3812: ARTEMIS-3057 Add min-free-disk-bytes feature

jbertram commented on pull request #3812:
URL: https://github.com/apache/activemq-artemis/pull/3812#issuecomment-952245832


   I definitely prefer leaving the existing behavior as-is and adding a new configuration parameter. Changing defaults in a minor a release typically results in a poor user experience.
   
   Also, I agree with Robbie about aligning the name with `max-disk-usage` so my vote would be to use `min-disk-free`.
   
   Lastly, I agree with Robbie that in case both `max-disk-usage` and `min-disk-free` are set then you must start blocking as soon as either one is reached. I think it would also be good to log a `WARN` message if both are configured stating that the configuration is ambiguous and the most conservative value will be used.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org