[GitHub] [pinot] walterddr commented on a diff in pull request #9571: [multi-stage] allow configurable timeout

[GitBox <gi...@apache.org>]

walterddr commented on code in PR #9571:
URL: https://github.com/apache/pinot/pull/9571#discussion_r1035527985


##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/service/QueryConfig.java:
##########
@@ -22,20 +22,43 @@
  * Configuration for setting up query runtime.
  */
 public class QueryConfig {
-  public static final long DEFAULT_TIMEOUT_NANO = 10_000_000_000L;
-
+  /**
+   * Configuration for mailbox data block size
+   */
   public static final String KEY_OF_MAX_INBOUND_QUERY_DATA_BLOCK_SIZE_BYTES = "pinot.query.runner.max.msg.size.bytes";
   public static final int DEFAULT_MAX_INBOUND_QUERY_DATA_BLOCK_SIZE_BYTES = 16 * 1024 * 1024;
 
+  public static final String KEY_OF_MAILBOX_TIMEOUT_MS = "pinot.query.runner.mailbox.timeout.ms";
+  public static final long DEFAULT_MAILBOX_TIMEOUT_MS = 10_000L;

Review Comment:
   yes but since we dont have that configuration hook up I will defer that to the next PR (see description above already mentioned this)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org