You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/01/20 15:15:18 UTC

[GitHub] [camel-k] doru1004 commented on pull request #1924: Fix modeline for inspect.

doru1004 commented on pull request #1924:
URL: https://github.com/apache/camel-k/pull/1924#issuecomment-763701047


   > I think it would be useful to provide tests for the various additional use cases:
   > 
   > * modeline-specified dependency added using mvn notation
   > * modeline-specified dependency added using "simple" notation for a camel component
   > * modeline-specified dependency added using jitpack notation
   > * several modeline-specified dependencies written on several lines
   
   I have added some tests. The value of the dependency does not matter at this point. What we were missing for modeline is the addition of these dependencies when inspect was used.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org