You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/08/07 20:40:07 UTC
Review Request 68263: Fixed Windows build break due to missing lambda
capture.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68263/
-----------------------------------------------------------
Review request for mesos and James Peach.
Repository: mesos
Description
-------
Since no default capture semantics were specified, `messageCount` was
not captured which MSVC refused to compile. Interestingly, clang emits
a warning if `messageCount` is captured explicitly, so we compromise
with an implicit value capture and explicit reference capture of `q`.
Diffs
-----
3rdparty/libprocess/src/tests/benchmarks.cpp 16b3bca44ca3e9a5fddd93fa02b9a3021c696fda
Diff: https://reviews.apache.org/r/68263/diff/1/
Testing
-------
Windows build, cquery (clang) did not emit warning.
Thanks,
Andrew Schwartzmeyer