You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Sailesh Mukil (Code Review)" <ge...@cloudera.org> on 2017/04/25 06:23:26 UTC
[Impala-ASF-CR] IMPALA-5244 test hdfs file open fail fails on local filesystem build
Sailesh Mukil has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6723
Change subject: IMPALA-5244 test_hdfs_file_open_fail fails on local filesystem build
......................................................................
IMPALA-5244 test_hdfs_file_open_fail fails on local filesystem build
This test had to be skipped for non HDFS filesystems.
Change-Id: I5318a5eb27b15fed5df770b9c3ea23e7e1a97a4c
---
M tests/common/skip.py
M tests/data_errors/test_data_errors.py
2 files changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/6723/1
--
To view, visit http://gerrit.cloudera.org:8080/6723
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5318a5eb27b15fed5df770b9c3ea23e7e1a97a4c
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
[Impala-ASF-CR] IMPALA-5244 test hdfs file open fail fails on local filesystem build
Posted by "Sailesh Mukil (Code Review)" <ge...@cloudera.org>.
Sailesh Mukil has posted comments on this change.
Change subject: IMPALA-5244 test_hdfs_file_open_fail fails on local filesystem build
......................................................................
Patch Set 1: Code-Review+2
> Were you able to validate the fix somehow ?
Thanks.
Yes, I made sure it got skipped for all non HDFS filesystems locally.
Carry +2.
--
To view, visit http://gerrit.cloudera.org:8080/6723
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5318a5eb27b15fed5df770b9c3ea23e7e1a97a4c
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5244 test hdfs file open fail fails on local filesystem build
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5244 test_hdfs_file_open_fail fails on local filesystem build
......................................................................
Patch Set 1:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/501/
--
To view, visit http://gerrit.cloudera.org:8080/6723
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5318a5eb27b15fed5df770b9c3ea23e7e1a97a4c
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5244 test hdfs file open fail fails on local filesystem build
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-5244 test_hdfs_file_open_fail fails on local filesystem build
......................................................................
IMPALA-5244 test_hdfs_file_open_fail fails on local filesystem build
This test had to be skipped for non HDFS filesystems.
Change-Id: I5318a5eb27b15fed5df770b9c3ea23e7e1a97a4c
Reviewed-on: http://gerrit.cloudera.org:8080/6723
Reviewed-by: Michael Ho <kw...@cloudera.com>
Reviewed-by: Sailesh Mukil <sa...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M tests/common/skip.py
M tests/data_errors/test_data_errors.py
2 files changed, 4 insertions(+), 2 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Michael Ho: Looks good to me, approved
Sailesh Mukil: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/6723
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5318a5eb27b15fed5df770b9c3ea23e7e1a97a4c
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
[Impala-ASF-CR] IMPALA-5244 test hdfs file open fail fails on local filesystem build
Posted by "Michael Ho (Code Review)" <ge...@cloudera.org>.
Michael Ho has posted comments on this change.
Change subject: IMPALA-5244 test_hdfs_file_open_fail fails on local filesystem build
......................................................................
Patch Set 1: Code-Review+2
Were you able to validate the fix somehow ?
--
To view, visit http://gerrit.cloudera.org:8080/6723
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5318a5eb27b15fed5df770b9c3ea23e7e1a97a4c
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5244 test hdfs file open fail fails on local filesystem build
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5244 test_hdfs_file_open_fail fails on local filesystem build
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/6723
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5318a5eb27b15fed5df770b9c3ea23e7e1a97a4c
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: No