You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ms...@apache.org on 2018/03/17 22:37:39 UTC
svn commit: r1827113 - in
/pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox: cff/CFFParser.java
ttf/GlyphSubstitutionTable.java
Author: msahyoun
Date: Sat Mar 17 22:37:39 2018
New Revision: 1827113
URL: http://svn.apache.org/viewvc?rev=1827113&view=rev
Log:
PDFBOX-4071: add annotation for Sonar to complement 'unused' annotation
Modified:
pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cff/CFFParser.java
pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/ttf/GlyphSubstitutionTable.java
Modified: pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cff/CFFParser.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cff/CFFParser.java?rev=1827113&r1=1827112&r2=1827113&view=diff
==============================================================================
--- pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cff/CFFParser.java (original)
+++ pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cff/CFFParser.java Sat Mar 17 22:37:39 2018
@@ -135,11 +135,11 @@ public class CFFParser
// this is OpenType font containing CFF data
// so find CFF tag
short numTables = input.readShort();
- @SuppressWarnings("unused")
+ @SuppressWarnings({"unused", "squid:S1854"})
short searchRange = input.readShort();
- @SuppressWarnings("unused")
+ @SuppressWarnings({"unused", "squid:S1854"})
short entrySelector = input.readShort();
- @SuppressWarnings("unused")
+ @SuppressWarnings({"unused", "squid:S1854"})
short rangeShift = input.readShort();
for (int q = 0; q < numTables; q++)
{
Modified: pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/ttf/GlyphSubstitutionTable.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/ttf/GlyphSubstitutionTable.java?rev=1827113&r1=1827112&r2=1827113&view=diff
==============================================================================
--- pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/ttf/GlyphSubstitutionTable.java (original)
+++ pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/ttf/GlyphSubstitutionTable.java Sat Mar 17 22:37:39 2018
@@ -62,13 +62,13 @@ public class GlyphSubstitutionTable exte
void read(TrueTypeFont ttf, TTFDataStream data) throws IOException
{
long start = data.getCurrentPosition();
- @SuppressWarnings("unused")
+ @SuppressWarnings({"unused", "squid:S1854"})
int majorVersion = data.readUnsignedShort();
int minorVersion = data.readUnsignedShort();
int scriptListOffset = data.readUnsignedShort();
int featureListOffset = data.readUnsignedShort();
int lookupListOffset = data.readUnsignedShort();
- @SuppressWarnings("unused")
+ @SuppressWarnings({"unused", "squid:S1854"})
long featureVariationsOffset = -1L;
if (minorVersion == 1L)
{
@@ -140,7 +140,7 @@ public class GlyphSubstitutionTable exte
{
data.seek(offset);
LangSysTable langSysTable = new LangSysTable();
- @SuppressWarnings("unused")
+ @SuppressWarnings({"unused", "squid:S1854"})
int lookupOrder = data.readUnsignedShort();
langSysTable.requiredFeatureIndex = data.readUnsignedShort();
int featureIndexCount = data.readUnsignedShort();
@@ -176,7 +176,7 @@ public class GlyphSubstitutionTable exte
{
data.seek(offset);
FeatureTable featureTable = new FeatureTable();
- @SuppressWarnings("unused")
+ @SuppressWarnings({"unused", "squid:S1854"})
int featureParams = data.readUnsignedShort();
int lookupIndexCount = data.readUnsignedShort();
featureTable.lookupListIndices = new int[lookupIndexCount];