[GitHub] [ignite-3] isapego commented on a diff in pull request #1310: IGNITE-18078 Format C++ code

[GitBox <gi...@apache.org>]

isapego commented on code in PR #1310:
URL: https://github.com/apache/ignite-3/pull/1310#discussion_r1013899389


##########
modules/platforms/cpp/tests/client-test/record_binary_view_test.cpp:
##########
@@ -143,25 +136,29 @@ TEST_F(record_binary_view_test, upsert_overrides_value) {
 }
 
 TEST_F(record_binary_view_test, upsert_empty_tuple_throws) {
-    EXPECT_THROW({
-        try {
-            tuple_view.upsert(nullptr, ignite_tuple());
-        } catch (const ignite_error& e) {
-            EXPECT_STREQ("Tuple can not be empty", e.what());
-            throw;
-        }
-    }, ignite_error);
+    EXPECT_THROW(
+        {
+            try {
+                tuple_view.upsert(nullptr, ignite_tuple());
+            } catch (const ignite_error &e) {
+                EXPECT_STREQ("Tuple can not be empty", e.what());
+                throw;
+            }
+        },
+        ignite_error);

Review Comment:
   Looks really weird as to me.



##########
modules/platforms/cpp/ignite/client/detail/cluster_connection.h:
##########
@@ -121,9 +121,10 @@ class cluster_connection : public std::enable_shared_from_this<cluster_connectio
      * @param rd Response reader function.
      * @param callback Callback to call on result.
      */
-    template <typename T>
-    void perform_request_rd(client_operation op, std::function<T(protocol::reader&)> rd, ignite_callback<T> callback) {
-        perform_request<T>(op, [](protocol::writer &) {}, std::move(rd), std::move(callback));
+    template<typename T>
+    void perform_request_rd(client_operation op, std::function<T(protocol::reader &)> rd, ignite_callback<T> callback) {
+        perform_request<T>(
+            op, [](protocol::writer &) {}, std::move(rd), std::move(callback));

Review Comment:
   Not sure why there is a line break?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org