You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org> on 2011/08/03 22:49:29 UTC

[jira] [Commented] (HIVE-2322) Add ColumnarSerDe to the list of native SerDes

    [ https://issues.apache.org/jira/browse/HIVE-2322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13079009#comment-13079009 ] 

jiraposter@reviews.apache.org commented on HIVE-2322:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1215/
-----------------------------------------------------------

(Updated 2011-08-03 20:47:48.616906)


Review request for hive and Paul Yang.


Changes
-------

Updated the query test results, which don't say "from deserializer" anymore.


Summary
-------

We store metadata about ColumnarSerDes in the metastore, so it should be considered a native SerDe. Then, column information can be retrieved from the metastore instead of from deserialization.


This addresses bug HIVE-2322.
    https://issues.apache.org/jira/browse/HIVE-2322


Diffs (updated)
-----

  trunk/ql/src/test/results/clientpositive/alter_merge_stats.q.out 1152020 
  trunk/ql/src/test/results/clientpositive/alter_partition_format_loc.q.out 1152020 
  trunk/ql/src/test/results/clientpositive/columnarserde_create_shortcut.q.out 1152020 
  trunk/ql/src/test/results/clientpositive/combine3.q.out 1152020 
  trunk/ql/src/test/results/clientpositive/create_1.q.out 1152020 
  trunk/ql/src/test/results/clientpositive/index_bitmap_rc.q.out 1152020 
  trunk/ql/src/test/results/clientpositive/index_compact_2.q.out 1152020 
  trunk/ql/src/test/results/clientpositive/index_compact_3.q.out 1152020 
  trunk/ql/src/test/results/clientpositive/index_creation.q.out 1152020 
  trunk/ql/src/test/results/clientpositive/rcfile_bigdata.q.out 1152020 
  trunk/ql/src/test/results/clientpositive/rcfile_columnar.q.out 1152020 
  trunk/ql/src/test/results/clientpositive/rcfile_default_format.q.out 1152020 
  trunk/ql/src/test/results/clientpositive/rcfile_merge4.q.out 1152020 
  trunk/ql/src/test/results/clientpositive/sample_islocalmode_hook.q.out 1152020 
  trunk/ql/src/test/results/clientpositive/smb_mapjoin_6.q.out 1152020 
  trunk/ql/src/test/results/clientpositive/smb_mapjoin_8.q.out 1152020 
  trunk/serde/src/java/org/apache/hadoop/hive/serde2/SerDeUtils.java 1152020 

Diff: https://reviews.apache.org/r/1215/diff


Testing
-------

describe formatted tmp_tbl_name;

now returns the column's comments instead of "from deserializer"


Thanks,

Sohan



> Add ColumnarSerDe to the list of native SerDes
> ----------------------------------------------
>
>                 Key: HIVE-2322
>                 URL: https://issues.apache.org/jira/browse/HIVE-2322
>             Project: Hive
>          Issue Type: Bug
>          Components: Metastore, Serializers/Deserializers
>            Reporter: Sohan Jain
>            Assignee: Sohan Jain
>         Attachments: HIVE-2322.1.patch
>
>
> We store metadata about ColumnarSerDes in the metastore, so it should be considered a native SerDe.  Then, column information can be retrieved from the metastore instead of from deserialization.
> Currently, for non-native SerDes, column comments are only shown as "from deserializer".  Adding ColumnarSerDe to the list of native SerDes will persist column comments.  See HIVE-2171 for persisting the column comments of custom SerDes.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira