You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Ugo Matrangolo (JIRA)" <ji...@apache.org> on 2007/04/18 10:35:15 UTC
[jira] Created: (DERBY-2562) conver/SpillHash.java to JUnit
conver/SpillHash.java to JUnit
------------------------------
Key: DERBY-2562
URL: https://issues.apache.org/jira/browse/DERBY-2562
Project: Derby
Issue Type: Test
Reporter: Ugo Matrangolo
Priority: Minor
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2562) conver/SpillHash.java to JUnit
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kathey Marsden updated DERBY-2562:
----------------------------------
Derby Info: (was: [Patch Available])
Thanks Ugo for the patch. I delted the old test file and canon as they are no longer needed.
Kathey
> conver/SpillHash.java to JUnit
> ------------------------------
>
> Key: DERBY-2562
> URL: https://issues.apache.org/jira/browse/DERBY-2562
> Project: Derby
> Issue Type: Test
> Components: Test
> Reporter: Ugo Matrangolo
> Assignee: Ugo Matrangolo
> Priority: Minor
> Attachments: DERBY-2562_diff_200507.txt, DERBY-2562_diff_290507.txt, DERBY-2562_stat_200507.txt, DERBY-2562_stat_290507.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (DERBY-2562) conver/SpillHash.java to JUnit
Posted by "Ugo Matrangolo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ugo Matrangolo reassigned DERBY-2562:
-------------------------------------
Assignee: Ugo Matrangolo
> conver/SpillHash.java to JUnit
> ------------------------------
>
> Key: DERBY-2562
> URL: https://issues.apache.org/jira/browse/DERBY-2562
> Project: Derby
> Issue Type: Test
> Reporter: Ugo Matrangolo
> Assigned To: Ugo Matrangolo
> Priority: Minor
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (DERBY-2562) conver/SpillHash.java to JUnit
Posted by "Ugo Matrangolo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ugo Matrangolo resolved DERBY-2562.
-----------------------------------
Resolution: Fixed
> conver/SpillHash.java to JUnit
> ------------------------------
>
> Key: DERBY-2562
> URL: https://issues.apache.org/jira/browse/DERBY-2562
> Project: Derby
> Issue Type: Test
> Components: Test
> Reporter: Ugo Matrangolo
> Assignee: Ugo Matrangolo
> Priority: Minor
> Attachments: DERBY-2562_diff_200507.txt, DERBY-2562_diff_290507.txt, DERBY-2562_stat_200507.txt, DERBY-2562_stat_290507.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2562) conver/SpillHash.java to JUnit
Posted by "Mike Matrigali (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Matrigali updated DERBY-2562:
----------------------------------
Component/s: Test
> conver/SpillHash.java to JUnit
> ------------------------------
>
> Key: DERBY-2562
> URL: https://issues.apache.org/jira/browse/DERBY-2562
> Project: Derby
> Issue Type: Test
> Components: Test
> Reporter: Ugo Matrangolo
> Assigned To: Ugo Matrangolo
> Priority: Minor
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2562) conver/SpillHash.java to JUnit
Posted by "Ugo Matrangolo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ugo Matrangolo updated DERBY-2562:
----------------------------------
Attachment: DERBY-2562_stat_290507.txt
DERBY-2562_diff_290507.txt
> conver/SpillHash.java to JUnit
> ------------------------------
>
> Key: DERBY-2562
> URL: https://issues.apache.org/jira/browse/DERBY-2562
> Project: Derby
> Issue Type: Test
> Components: Test
> Reporter: Ugo Matrangolo
> Assignee: Ugo Matrangolo
> Priority: Minor
> Attachments: DERBY-2562_diff_200507.txt, DERBY-2562_diff_290507.txt, DERBY-2562_stat_200507.txt, DERBY-2562_stat_290507.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2562) conver/SpillHash.java to JUnit
Posted by "Ugo Matrangolo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ugo Matrangolo updated DERBY-2562:
----------------------------------
Attachment: DERBY-2562_stat_200507.txt
DERBY-2562_diff_200507.txt
Spillhash.java conversion to JUnit.
> conver/SpillHash.java to JUnit
> ------------------------------
>
> Key: DERBY-2562
> URL: https://issues.apache.org/jira/browse/DERBY-2562
> Project: Derby
> Issue Type: Test
> Components: Test
> Reporter: Ugo Matrangolo
> Assigned To: Ugo Matrangolo
> Priority: Minor
> Attachments: DERBY-2562_diff_200507.txt, DERBY-2562_stat_200507.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2562) conver/SpillHash.java to JUnit
Posted by "Ugo Matrangolo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ugo Matrangolo updated DERBY-2562:
----------------------------------
Derby Info: [Patch Available]
> conver/SpillHash.java to JUnit
> ------------------------------
>
> Key: DERBY-2562
> URL: https://issues.apache.org/jira/browse/DERBY-2562
> Project: Derby
> Issue Type: Test
> Components: Test
> Reporter: Ugo Matrangolo
> Assigned To: Ugo Matrangolo
> Priority: Minor
> Attachments: DERBY-2562_diff_200507.txt, DERBY-2562_stat_200507.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2562) conver/SpillHash.java to JUnit
Posted by "Ugo Matrangolo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12499934 ]
Ugo Matrangolo commented on DERBY-2562:
---------------------------------------
Hi Knut,
thank you for your comments. Attached there is the modified code.
--Ugo.
> conver/SpillHash.java to JUnit
> ------------------------------
>
> Key: DERBY-2562
> URL: https://issues.apache.org/jira/browse/DERBY-2562
> Project: Derby
> Issue Type: Test
> Components: Test
> Reporter: Ugo Matrangolo
> Assignee: Ugo Matrangolo
> Priority: Minor
> Attachments: DERBY-2562_diff_200507.txt, DERBY-2562_diff_290507.txt, DERBY-2562_stat_200507.txt, DERBY-2562_stat_290507.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2562) conver/SpillHash.java to JUnit
Posted by "Myrna van Lunteren (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Myrna van Lunteren updated DERBY-2562:
--------------------------------------
Fix Version/s: 10.3.0.0
> conver/SpillHash.java to JUnit
> ------------------------------
>
> Key: DERBY-2562
> URL: https://issues.apache.org/jira/browse/DERBY-2562
> Project: Derby
> Issue Type: Test
> Components: Test
> Reporter: Ugo Matrangolo
> Assignee: Ugo Matrangolo
> Priority: Minor
> Fix For: 10.3.0.0
>
> Attachments: DERBY-2562_diff_200507.txt, DERBY-2562_diff_290507.txt, DERBY-2562_stat_200507.txt, DERBY-2562_stat_290507.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2562) conver/SpillHash.java to JUnit
Posted by "Ugo Matrangolo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12497237 ]
Ugo Matrangolo commented on DERBY-2562:
---------------------------------------
The attached diff files are the conversion of the Spillhash harness test to JUnit.
I split the the test in two distinct parts: the first run is against a light load on the test table where the second run exercise the same table filled with a lot of rows. I used a CleanDatabaseTestSetup to create the initial schema on the db, then two distinct BaseJDBCTestSetup to fill tables for the two distinct phases.
The rest of the code in only a 1-1 translation using assert/fail statements in place of the old checks.
Please review,
--Ugo.
> conver/SpillHash.java to JUnit
> ------------------------------
>
> Key: DERBY-2562
> URL: https://issues.apache.org/jira/browse/DERBY-2562
> Project: Derby
> Issue Type: Test
> Components: Test
> Reporter: Ugo Matrangolo
> Assigned To: Ugo Matrangolo
> Priority: Minor
> Attachments: DERBY-2562_diff_200507.txt, DERBY-2562_stat_200507.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2562) conver/SpillHash.java to JUnit
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12499442 ]
Knut Anders Hatlen commented on DERBY-2562:
-------------------------------------------
Hi Ugo,
The patch looks good to me. A couple of tiny comments:
- I think joinStmt and distinctStmt should have been instance variables, not static variables. With that change, you'll also need a tearDown() method which closes those objects, sets them to null and calls super.tearDown()
- checkAllCa1() has a finally block with clean-up code. Finally blocks could be dangerous in tests since errors that happen in the finally block will hide errors in the try block. In this case, I think it would be OK just to remove the try/finally.
Thanks!
> conver/SpillHash.java to JUnit
> ------------------------------
>
> Key: DERBY-2562
> URL: https://issues.apache.org/jira/browse/DERBY-2562
> Project: Derby
> Issue Type: Test
> Components: Test
> Reporter: Ugo Matrangolo
> Assigned To: Ugo Matrangolo
> Priority: Minor
> Attachments: DERBY-2562_diff_200507.txt, DERBY-2562_stat_200507.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (DERBY-2562) conver/SpillHash.java to JUnit
Posted by "Myrna van Lunteren (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Myrna van Lunteren closed DERBY-2562.
-------------------------------------
> conver/SpillHash.java to JUnit
> ------------------------------
>
> Key: DERBY-2562
> URL: https://issues.apache.org/jira/browse/DERBY-2562
> Project: Derby
> Issue Type: Test
> Components: Test
> Reporter: Ugo Matrangolo
> Assignee: Ugo Matrangolo
> Priority: Minor
> Fix For: 10.3.0.0
>
> Attachments: DERBY-2562_diff_200507.txt, DERBY-2562_diff_290507.txt, DERBY-2562_stat_200507.txt, DERBY-2562_stat_290507.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.