You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Dan Hecht (Code Review)" <ge...@cloudera.org> on 2018/06/25 21:49:32 UTC
[Impala-ASF-CR] IMPALA-7210: global debug actions should be case insensitive
Dan Hecht has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10814
Change subject: IMPALA-7210: global debug actions should be case insensitive
......................................................................
IMPALA-7210: global debug actions should be case insensitive
The ExecNode debug actions don't care about case so better
to be consistent.
Testing: verify that this works:
set debug_action=coord_before_exec_rpc:sleep@1000
Change-Id: Ia3f738caeb602afce4ca638ce354302e521187dc
---
M be/src/util/debug-util.cc
1 file changed, 7 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/14/10814/1
--
To view, visit http://gerrit.cloudera.org:8080/10814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia3f738caeb602afce4ca638ce354302e521187dc
Gerrit-Change-Number: 10814
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Hecht <dh...@cloudera.com>
[Impala-ASF-CR] IMPALA-7210: global debug actions should be case insensitive
Posted by "Dan Hecht (Code Review)" <ge...@cloudera.org>.
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10814 )
Change subject: IMPALA-7210: global debug actions should be case insensitive
......................................................................
Patch Set 3: Code-Review+2
Carry
--
To view, visit http://gerrit.cloudera.org:8080/10814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3f738caeb602afce4ca638ce354302e521187dc
Gerrit-Change-Number: 10814
Gerrit-PatchSet: 3
Gerrit-Owner: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 26 Jun 2018 15:36:18 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7210: global debug actions should be case insensitive
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10814 )
Change subject: IMPALA-7210: global debug actions should be case insensitive
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2738/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/10814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3f738caeb602afce4ca638ce354302e521187dc
Gerrit-Change-Number: 10814
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 25 Jun 2018 22:17:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7210: global debug actions should be case insensitive
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10814 )
Change subject: IMPALA-7210: global debug actions should be case insensitive
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2743/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/10814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3f738caeb602afce4ca638ce354302e521187dc
Gerrit-Change-Number: 10814
Gerrit-PatchSet: 3
Gerrit-Owner: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 26 Jun 2018 15:36:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7210: global debug actions should be case insensitive
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10814 )
Change subject: IMPALA-7210: global debug actions should be case insensitive
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3f738caeb602afce4ca638ce354302e521187dc
Gerrit-Change-Number: 10814
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 25 Jun 2018 22:01:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7210: global debug actions should be case insensitive
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10814 )
Change subject: IMPALA-7210: global debug actions should be case insensitive
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/10814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3f738caeb602afce4ca638ce354302e521187dc
Gerrit-Change-Number: 10814
Gerrit-PatchSet: 3
Gerrit-Owner: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 26 Jun 2018 19:00:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7210: global debug actions should be case insensitive
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10814 )
Change subject: IMPALA-7210: global debug actions should be case insensitive
......................................................................
IMPALA-7210: global debug actions should be case insensitive
The ExecNode debug actions don't care about case so better
to be consistent.
Testing: verify that this works:
set debug_action=coord_before_exec_rpc:sleep@1000
Change-Id: Ia3f738caeb602afce4ca638ce354302e521187dc
Reviewed-on: http://gerrit.cloudera.org:8080/10814
Reviewed-by: Dan Hecht <dh...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/util/debug-util.cc
1 file changed, 7 insertions(+), 4 deletions(-)
Approvals:
Dan Hecht: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/10814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia3f738caeb602afce4ca638ce354302e521187dc
Gerrit-Change-Number: 10814
Gerrit-PatchSet: 4
Gerrit-Owner: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-7210: global debug actions should be case insensitive
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10814 )
Change subject: IMPALA-7210: global debug actions should be case insensitive
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3f738caeb602afce4ca638ce354302e521187dc
Gerrit-Change-Number: 10814
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 25 Jun 2018 22:17:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7210: global debug actions should be case insensitive
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10814 )
Change subject: IMPALA-7210: global debug actions should be case insensitive
......................................................................
Patch Set 2: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/2738/
--
To view, visit http://gerrit.cloudera.org:8080/10814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3f738caeb602afce4ca638ce354302e521187dc
Gerrit-Change-Number: 10814
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 26 Jun 2018 08:17:36 +0000
Gerrit-HasComments: No