You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Takeshi Yamamuro (Jira)" <ji...@apache.org> on 2021/05/08 12:45:00 UTC
[jira] [Resolved] (SPARK-35327) Filters out the TPC-DS queries that
can cause flaky test results
[ https://issues.apache.org/jira/browse/SPARK-35327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Takeshi Yamamuro resolved SPARK-35327.
--------------------------------------
Fix Version/s: 3.2.0
Assignee: Takeshi Yamamuro
Resolution: Fixed
Resolved by https://github.com/apache/spark/pull/32454
> Filters out the TPC-DS queries that can cause flaky test results
> ----------------------------------------------------------------
>
> Key: SPARK-35327
> URL: https://issues.apache.org/jira/browse/SPARK-35327
> Project: Spark
> Issue Type: Test
> Components: SQL, Tests
> Affects Versions: 3.0.2, 3.1.1, 3.2.0
> Reporter: Takeshi Yamamuro
> Assignee: Takeshi Yamamuro
> Priority: Major
> Fix For: 3.2.0
>
>
> This ticket aims at filtering out TPCDS v1.4 q6 and q75 in `TPCDSQueryTestSuite`.
> I saw`TPCDSQueryTestSuite` failed nondeterministically because output row orders were different with those in the golden files. For example, the failure in the GA job, https://github.com/linhongliu-db/spark/runs/2507928605?check_suite_focus=true, happened because the `tpcds/q6.sql` query output rows were only sorted by `cnt`:
> https://github.com/apache/spark/blob/a0c76a8755a148e2bd774edcda12fe20f2f38c75/sql/core/src/test/resources/tpcds/q6.sql#L20
> Actually, `tpcds/q6.sql` and `tpcds-v2.7.0/q6.sql` are almost the same and the only difference is that `tpcds-v2.7.0/q6.sql` sorts both `cnt` and `a.ca_state`:
> https://github.com/apache/spark/blob/a0c76a8755a148e2bd774edcda12fe20f2f38c75/sql/core/src/test/resources/tpcds-v2.7.0/q6.sql#L22
> So, I think it's okay just to test `tpcds-v2.7.0/q6.sql` in this case (q75 has the same issue).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org