You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/07/20 16:03:19 UTC

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4453: Issue #4450: Support parsing of `Order By` (with group-by) clause in PQL compiler.

kishoreg commented on a change in pull request #4453: Issue #4450: Support parsing of `Order By` (with group-by) clause in PQL compiler.
URL: https://github.com/apache/incubator-pinot/pull/4453#discussion_r305584907
 
 

 ##########
 File path: pinot-common/src/thrift/request.thrift
 ##########
 @@ -154,6 +154,7 @@ struct BrokerRequest {
  15: optional HavingFilterQuery havingFilterQuery;
  16: optional HavingFilterQueryMap havingFilterSubQueryMap;
  17: optional query.PinotQuery pinotQuery;
+ 18: optional list<SelectionSort> orderBy;
 
 Review comment:
   is it possible to rename SelectionSort to OrderBy? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org