You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "allisonport-db (via GitHub)" <gi...@apache.org> on 2023/07/05 23:12:08 UTC
[GitHub] [spark] allisonport-db opened a new pull request, #41868: [SPARK-44313] Fix generated column expression validation when there is a char/varchar column in the schema
allisonport-db opened a new pull request, #41868:
URL: https://github.com/apache/spark/pull/41868
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
#38823 added support for defining generated columns in create table statements. This included generation expression validation. This validation currently erroneously fails when there are char or varchar columns anywhere in the table schema since the checkAnalysis fails here https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/GeneratedColumn.scala#L123.
This PR replaces any char/varchar columns in the schema with a string before analysis.
### Why are the changes needed?
This should not fail.
```
CREATE TABLE default.example (
name VARCHAR(64),
tstamp TIMESTAMP,
tstamp_date DATE GENERATED ALWAYS AS (CAST(tstamp as DATE))
)
```
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Adds a unit test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn closed pull request #41868: [SPARK-44313][SQL] Fix generated column expression validation when there is a char/varchar column in the schema
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn closed pull request #41868: [SPARK-44313][SQL] Fix generated column expression validation when there is a char/varchar column in the schema
URL: https://github.com/apache/spark/pull/41868
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #41868: [SPARK-44313][SQL] Fix generated column expression validation when there is a char/varchar column in the schema
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on PR #41868:
URL: https://github.com/apache/spark/pull/41868#issuecomment-1622860559
thanks @allisonport-db @cloud-fan @ShreyeshArangath merged to master and 3.4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org