You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by frreiss <gi...@git.apache.org> on 2016/03/08 01:43:14 UTC

[GitHub] spark pull request: [SPARK-13253] [SQL]avoid checking nullability ...

Github user frreiss commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11184#discussion_r55299643
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala ---
    @@ -87,7 +87,7 @@ trait NamedExpression extends Expression {
     
       protected def typeSuffix =
         if (resolved) {
    -      dataType match {
    +      prettyDataType match {
    --- End diff --
    
    This line appears to be the only code that consumes the new `prettyDataType` attribute


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org