You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2019/07/03 20:54:00 UTC
[jira] [Work logged] (HDDS-1761) Fix class hierarchy for KeyRequest
and FileRequest classes.
[ https://issues.apache.org/jira/browse/HDDS-1761?focusedWorklogId=271878&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-271878 ]
ASF GitHub Bot logged work on HDDS-1761:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Jul/19 20:53
Start Date: 03/Jul/19 20:53
Worklog Time Spent: 10m
Work Description: bharatviswa504 commented on pull request #1052: HDDS-1761. Fix class hierarchy for KeyRequest and FileRequest classes.
URL: https://github.com/apache/hadoop/pull/1052
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 271878)
Time Spent: 10m
Remaining Estimate: 0h
> Fix class hierarchy for KeyRequest and FileRequest classes.
> -----------------------------------------------------------
>
> Key: HDDS-1761
> URL: https://issues.apache.org/jira/browse/HDDS-1761
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.5.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The patch looks mostly fine to me. A few minor comments. -and one type error that needs to be fixed.-
> I would like to see the class hierarchy refactored in a follow up patch. {{OMFileCreateRequest}}should not extend {{OMKeyCreateRequest}}. Instead they should both extend an abstract class that encapsulates the common functionality.
> Generally deriving from _concrete_ classes is a bad idea.
>
> This Jira is created based on [~arp] comment during review of HDDS-1731
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org