You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by "Ajay Yadava (JIRA)" <ji...@apache.org> on 2015/06/03 07:59:50 UTC
[jira] [Commented] (FALCON-1104) Exception while adding process
instance to graphdb when feed has partition expression
[ https://issues.apache.org/jira/browse/FALCON-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14570326#comment-14570326 ]
Ajay Yadava commented on FALCON-1104:
-------------------------------------
Minor nit:
{code}
- + SchemaHelper.formatDateUTCToISO8601(instance, FEED_INSTANCE_FORMAT);
+ + SchemaHelper.formatDateUTC(FeedHelper.getDate(feedPathTemplate,
+ new Path(feedInstancePath), TimeZone.getTimeZone("UTC")));
{code}
As a matter of programming style we are discouraging such expressions in function calls for readability reasons. Can you please put the FeedHelper.getDate() call on a separate line?
Everything else looks good to me.
> Exception while adding process instance to graphdb when feed has partition expression
> -------------------------------------------------------------------------------------
>
> Key: FALCON-1104
> URL: https://issues.apache.org/jira/browse/FALCON-1104
> Project: Falcon
> Issue Type: Bug
> Reporter: pavan kumar kolamuri
> Assignee: pavan kumar kolamuri
> Priority: Minor
> Attachments: FALCON-1104-v1.patch, FALCON-1104-v2.patch, FALCON-1104.patch
>
>
> Issue in addition of process instance to metadata store, if the process instance consumes feed of specific partition . It will throw FalconException
> {noformat}
> java.lang.StringIndexOutOfBoundsException: String index out of range: 18
> at java.lang.String.substring(String.java:1907)
> at org.apache.falcon.entity.v0.SchemaHelper.formatDateUTCToISO8601(SchemaHelper.java:64)
> at org.apache.falcon.metadata.InstanceRelationshipGraphBuilder.getFileSystemFeedInstanceName(InstanceRelationshipGraphBuilder.java:307)
> at org.apache.falcon.metadata.InstanceRelationshipGraphBuilder.getFeedInstanceName(InstanceRelationshipGraphBuilder.java:279)
> at org.apache.falcon.metadata.InstanceRelationshipGraphBuilder.addFeedInstance(InstanceRelationshipGraphBuilder.java:243)
> at org.apache.falcon.metadata.InstanceRelationshipGraphBuilder.addInputFeedInstances(InstanceRelationshipGraphBuilder.java:171)
> at org.apache.falcon.metadata.MetadataMappingService.onProcessInstanceExecuted(MetadataMappingService.java:290)
> at org.apache.falcon.metadata.MetadataMappingService.onSuccess(MetadataMappingService.java:264)
> at org.apache.falcon.workflow.WorkflowJobEndNotificationService.notifySuccess(WorkflowJobEndNotificationService.java:101)
> at org.apache.falcon.messaging.JMSMessageConsumer.onSuccess(JMSMessageConsumer.java:138)
> at org.apache.falcon.messaging.JMSMessageConsumer.onMessage(JMSMessageConsumer.java:110)
> at org.apache.activemq.ActiveMQMessageConsumer.dispatch(ActiveMQMessageConsumer.java:1229)
> at org.apache.activemq.ActiveMQSessionExecutor.dispatch(ActiveMQSessionExecutor.java:134)
> at org.apache.activemq.ActiveMQSessionExecutor.iterate(ActiveMQSessionExecutor.java:205)
> at org.apache.activemq.thread.PooledTaskRunner.runTask(PooledTaskRunner.java:122)
> at org.apache.activemq.thread.PooledTaskRunner$1.run(PooledTaskRunner.java:43)
> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)