You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/02/07 07:35:42 UTC
[GitHub] [incubator-gobblin] autumnust opened a new pull request #2884:
[GOBBLIN-1044] Enrich fork-failure information when task failed
autumnust opened a new pull request #2884: [GOBBLIN-1044] Enrich fork-failure information when task failed
URL: https://github.com/apache/incubator-gobblin/pull/2884
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-XXX
### Description
- [ ] Here are some details about my PR, including screenshots (if applicable):
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] asfgit closed pull request #2884:
[GOBBLIN-1044] Enrich fork-failure information when task failed
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #2884: [GOBBLIN-1044] Enrich fork-failure information when task failed
URL: https://github.com/apache/incubator-gobblin/pull/2884
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] sv2000 commented on issue #2884: [GOBBLIN-1044]
Enrich fork-failure information when task failed
Posted by GitBox <gi...@apache.org>.
sv2000 commented on issue #2884: [GOBBLIN-1044] Enrich fork-failure information when task failed
URL: https://github.com/apache/incubator-gobblin/pull/2884#issuecomment-583548516
@autumnust Can you check the travis failure? Looks good otherwise.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] autumnust commented on issue #2884:
[GOBBLIN-1044] Enrich fork-failure information when task failed
Posted by GitBox <gi...@apache.org>.
autumnust commented on issue #2884: [GOBBLIN-1044] Enrich fork-failure information when task failed
URL: https://github.com/apache/incubator-gobblin/pull/2884#issuecomment-583678879
> @autumnust Can you check the travis failure? Looks good otherwise.
The travis has passed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] codecov-io commented on issue #2884:
[GOBBLIN-1044] Enrich fork-failure information when task failed
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #2884: [GOBBLIN-1044] Enrich fork-failure information when task failed
URL: https://github.com/apache/incubator-gobblin/pull/2884#issuecomment-583584798
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2884?src=pr&el=h1) Report
> Merging [#2884](https://codecov.io/gh/apache/incubator-gobblin/pull/2884?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/ef3003c85531aaeacb760a4e30fca2d3069001aa?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `62.5%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2884?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2884 +/- ##
===========================================
- Coverage 45.73% 45.7% -0.03%
- Complexity 9112 9117 +5
===========================================
Files 1921 1923 +2
Lines 72391 72481 +90
Branches 7967 7976 +9
===========================================
+ Hits 33106 33129 +23
- Misses 36262 36325 +63
- Partials 3023 3027 +4
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2884?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...metastore/FileContextBasedFsStateStoreFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2884/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRhc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0YXN0b3JlL0ZpbGVDb250ZXh0QmFzZWRGc1N0YXRlU3RvcmVGYWN0b3J5LmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...src/main/java/org/apache/gobblin/runtime/Task.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2884/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvVGFzay5qYXZh) | `66.89% <62.5%> (-0.16%)` | `84 <2> (+2)` | |
| [...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2884/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh) | `35.51% <0%> (-3.74%)` | `12% <0%> (-1%)` | |
| [...a/org/apache/gobblin/cluster/GobblinHelixTask.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2884/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4VGFzay5qYXZh) | `77.41% <0%> (-3.02%)` | `6% <0%> (+1%)` | |
| [...lin/restli/throttling/ZookeeperLeaderElection.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2884/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2UvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2Utc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3Jlc3RsaS90aHJvdHRsaW5nL1pvb2tlZXBlckxlYWRlckVsZWN0aW9uLmphdmE=) | `70% <0%> (-2.23%)` | `13% <0%> (ø)` | |
| [...lin/elasticsearch/writer/FutureCallbackHolder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2884/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tZWxhc3RpY3NlYXJjaC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9lbGFzdGljc2VhcmNoL3dyaXRlci9GdXR1cmVDYWxsYmFja0hvbGRlci5qYXZh) | `61.42% <0%> (-1.43%)` | `4% <0%> (ø)` | |
| [...main/java/org/apache/gobblin/util/HadoopUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2884/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvSGFkb29wVXRpbHMuamF2YQ==) | `30.2% <0%> (-0.68%)` | `24% <0%> (-1%)` | |
| [...pache/gobblin/cluster/GobblinHelixTaskFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2884/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4VGFza0ZhY3RvcnkuamF2YQ==) | `100% <0%> (ø)` | `10% <0%> (+2%)` | :arrow_up: |
| [...gobblin/cluster/HelixAssignedParticipantCheck.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2884/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhBc3NpZ25lZFBhcnRpY2lwYW50Q2hlY2suamF2YQ==) | `0% <0%> (ø)` | `0% <0%> (?)` | |
| [...org/apache/gobblin/commit/CommitStepException.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2884/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vY29tbWl0L0NvbW1pdFN0ZXBFeGNlcHRpb24uamF2YQ==) | `0% <0%> (ø)` | `0% <0%> (?)` | |
| ... and [2 more](https://codecov.io/gh/apache/incubator-gobblin/pull/2884/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2884?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2884?src=pr&el=footer). Last update [ef3003c...4ba98a2](https://codecov.io/gh/apache/incubator-gobblin/pull/2884?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services