You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2019/08/19 21:58:19 UTC
Review Request 71317: Added draining test for momentarily disconnected
agents.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71317/
-----------------------------------------------------------
Review request for mesos, Benno Evers and Greg Mann.
Bugs: MESOS-9892
https://issues.apache.org/jira/browse/MESOS-9892
Repository: mesos
Description
-------
This exercises the agent draining code when the agent is disconnected
from the master at the time of starting draining. Draining is expected
to proceed once the agent reregisters.
Diffs
-----
src/tests/master_draining_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/71317/diff/1/
Testing
-------
make check
Thanks,
Joseph Wu
Re: Review Request 71317: Added draining test for momentarily
disconnected agents.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71317/#review217365
-----------------------------------------------------------
src/tests/master_draining_tests.cpp
Lines 313-318 (patched)
<https://reviews.apache.org/r/71317/#comment304659>
Is this used?
src/tests/master_draining_tests.cpp
Lines 324 (patched)
<https://reviews.apache.org/r/71317/#comment304660>
Is the agent unreachable? Can we verify that the agent is in the correct state via master API output? Ditto in the second test below.
src/tests/master_draining_tests.cpp
Lines 357-358 (patched)
<https://reviews.apache.org/r/71317/#comment304661>
Can we verify that the agent is in the correct drain state via master API output? Here and below.
src/tests/master_draining_tests.cpp
Lines 713-721 (patched)
<https://reviews.apache.org/r/71317/#comment304662>
Could you move this expectation down above the agent restart?
- Greg Mann
On Aug. 19, 2019, 9:58 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71317/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2019, 9:58 p.m.)
>
>
> Review request for mesos, Benno Evers and Greg Mann.
>
>
> Bugs: MESOS-9892
> https://issues.apache.org/jira/browse/MESOS-9892
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This exercises the agent draining code when the agent is disconnected
> from the master at the time of starting draining. Draining is expected
> to proceed once the agent reregisters.
>
>
> Diffs
> -----
>
> src/tests/master_draining_tests.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/71317/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 71317: Added draining test for momentarily
disconnected agents.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71317/#review217418
-----------------------------------------------------------
Fix it, then Ship it!
Looks great! Just one small comment below.
src/tests/master_draining_tests.cpp
Lines 757 (patched)
<https://reviews.apache.org/r/71317/#comment304699>
The agent isn't unreachable here
- Greg Mann
On Aug. 23, 2019, 7:22 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71317/
> -----------------------------------------------------------
>
> (Updated Aug. 23, 2019, 7:22 p.m.)
>
>
> Review request for mesos, Benno Evers and Greg Mann.
>
>
> Bugs: MESOS-9892
> https://issues.apache.org/jira/browse/MESOS-9892
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This exercises the agent draining code when the agent is disconnected
> from the master at the time of starting draining. Draining is expected
> to proceed once the agent reregisters.
>
>
> Diffs
> -----
>
> src/tests/master_draining_tests.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/71317/diff/3/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 71317: Added draining test for momentarily
disconnected agents.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71317/
-----------------------------------------------------------
(Updated Aug. 23, 2019, 12:22 p.m.)
Review request for mesos, Benno Evers and Greg Mann.
Changes
-------
Flipped the order of some `EXPECT_EQ` statements since the type inference causes a warning.
Bugs: MESOS-9892
https://issues.apache.org/jira/browse/MESOS-9892
Repository: mesos
Description
-------
This exercises the agent draining code when the agent is disconnected
from the master at the time of starting draining. Draining is expected
to proceed once the agent reregisters.
Diffs (updated)
-----
src/tests/master_draining_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/71317/diff/3/
Changes: https://reviews.apache.org/r/71317/diff/2-3/
Testing
-------
make check
Thanks,
Joseph Wu
Re: Review Request 71317: Added draining test for momentarily
disconnected agents.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71317/
-----------------------------------------------------------
(Updated Aug. 22, 2019, 11:38 a.m.)
Review request for mesos, Benno Evers and Greg Mann.
Changes
-------
* Removed unused expectation.
* Added some more verification about disconnection and drain state.
Bugs: MESOS-9892
https://issues.apache.org/jira/browse/MESOS-9892
Repository: mesos
Description
-------
This exercises the agent draining code when the agent is disconnected
from the master at the time of starting draining. Draining is expected
to proceed once the agent reregisters.
Diffs (updated)
-----
src/tests/master_draining_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/71317/diff/2/
Changes: https://reviews.apache.org/r/71317/diff/1-2/
Testing
-------
make check
Thanks,
Joseph Wu